[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#605911: (future) unblock: network-manager/0.8.1-6



Am 06.12.2010 23:00, schrieb Mehdi Dogguy:
> On 12/04/2010 05:26 PM, Michael Biebl wrote:
>>
>> network-manager (0.8.1-6) unstable; urgency=low
>>
>>   * debian/patches/40-umanaged-interfaces.patch
>>     - For devices to be marked unmanaged, do not require a valid connection
>>       configuration. (Closes: #569215)

An example here is:

iface wlan0 inet wlan0
	wpa-roam /etc/wpa_supplicant/wpa_supplicant.conf

This is configuration that is incomplete/not understood by
network-manager. We still want to mark the interface as unmanaged though
if managed=false.


>>   * debian/patches/50-bridge-interfaces.patch
>>     - Parse bridge configurations in /etc/network/interfaces and add
>>       interfaces defined via bridge_ports to well_known_interfaces. This
>>       allows to mark those interfaces as unmanaged if managed=false.
>>       The "all" keyword and regexes are not supported and simply skipped.
>>       (Closes: #530335)
>>
> 
> I'm sure that I misunderstood something but I'll ask question anyway :)
> 
> I read the following lines in the diff:
> 
> + /* Skip crazy stuff like regex or all */
> + if (!strcmp ("all", token)) {
> +         continue;
> + }
> + /* Small SM to skip everything inside regex */
> + if (!strcmp ("regex", token)) {
> +         state++;
> +         continue;
> + }
> 
> It doesn't look like "regex" is skipped here (not like "all" at least).

If we find "regex" ,the start of a regular expression, we increment the
counter, and skip the token via continue. If we find "noregex", the end
of the regular expression, we decrement the counter and also skip the
token via continue.
As long as we are inside a regular expression (counter > 0), we skip any
tokens.

> And, do you have an example of file to see what's the intended behavior?
> (That would make it easier for me for the reading)

Example 1:
iface br0 inet manual
	bridge_ports all wlan0

→ wlan0 will be marked unmanaged

iface br0 inet manual
       bridge_ports wlan0 regex (eth0|vif).* noregex wlan1

→ wlan0 and wlan1 will be marked unmanaged

See also
http://manpages.ubuntu.com/manpages/maverick/man5/bridge-utils-interfaces.5.html

Added back the CC to the bug report.

Cheers,
Michael

-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: