[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#605249: unblock: typo3-src/4.3.8+dfsg1-1

On Sun, 2010-11-28 at 14:56 +0100, Holger Levsen wrote:
> please unblock typo3-src/4.3.8+dfsg1-1 which fixes a serious bug.
>  typo3-src (4.3.8+dfsg1-1) unstable; urgency=low
>  .
>    * Removed typo3/contrib/jsmin/jsmin.php because of non free license
>      (Closes: 602250)

The minifyJavaScript function in t3lib/class.t3lib_div.php, which used
to call jsmin.php, begins with a comment which says:

* @return      string  Minified script or source string if error happened

However, as the entire body of the function except "$script =
trim($script);" has been commented out, it currently returns nothing.  A
quick survey of the source indicates that it is always called as:

$var = minifyJavascript($var, $errorvar)

so this seems like it would break each of the callers?



Reply to: