[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#603470: libmapnik0.7: package linked against broken external AGG



Dear Security and Release Teams,

On Mon, 15 Nov 2010 12:07:56 +0100, Sven Geggus wrote:

> Francesco P. Lovergine schrieb am Montag, den 15. November um 11:19 Uhr:
> 
> > My best guessing is moving to the embedded copy if resulting issues are
> > grave enough to compromise its use.
> 
> There are occasional hangs of the rendering library resulting in 100% CPU
> usage.

I'm writing to you because of #603470. The obvious solution is to link against
the internal patched libagg, and this is what mapnik upstream is expecting us to
do.

The AGG+Mapnik case is unfortunate; the problem is twofold: upstream relicensed
the code from MIT to GPL-2 from versions 2.4 → 2.5 (and Mapnik is LGPL, so
we're basically restricting its usage when linking to the GPL library), and
development of AGG has now stopped.
It seems like there are some forks in the wild of the 2.4 branch (because of
license concerns). Mapnik embeds a patched 2.3 version of AGG -- I'd like to
know if:

- security team: would it be acceptable to use the embedded copy?
- release team: would such a change have a freeze exception granted? (attaching
  diff -- the only change is the drop of INTERNAL_LIBAGG=no, but I split it to
  make it easier to read in future)

Thank you,
David

-- 
 . ''`.   Debian developer | http://wiki.debian.org/DavidPaleino
 : :'  : Linuxer #334216 --|-- http://www.hanskalabs.net/
 `. `'`  GPG: 1392B174 ----|---- http://deb.li/dapal
   `-   2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174
diff --git a/debian/changelog b/debian/changelog
index 119090b..019f990 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+mapnik (0.7.1-3) UNRELEASED; urgency=low
+
+  * Compile using internal copy of libagg. (Closes: #603470)
+
+ -- David Paleino <dapal@debian.org>  Mon, 15 Nov 2010 16:05:05 +0100
+
 mapnik (0.7.1-2) unstable; urgency=low
 
   * debian/patches/03-fix_ImportError_mips.patch added, fixes
diff --git a/debian/control b/debian/control
index 678646c..dcd8651 100644
--- a/debian/control
+++ b/debian/control
@@ -26,7 +26,6 @@ Build-Depends:
  libfribidi-dev,
  libgdal1-dev,
  libxml2-dev,
- libagg-dev,
  libicu-dev,
  libcairo2-dev,
  libcairomm-1.0-dev,
diff --git a/debian/rules b/debian/rules
index a19bd94..067d3c2 100755
--- a/debian/rules
+++ b/debian/rules
@@ -5,7 +5,12 @@
 #export DH_VERBOSE=1
 
 # scons flags
-SCONS_FLAGS=INPUT_PLUGINS=raster,sqlite,postgis,ogr,shape,osm,gdal,kismet PROJ_INCLUDES=/usr/include PROJ_LIBS=/usr/lib INTERNAL_LIBAGG=no SYSTEM_FONTS=/usr/share/fonts/truetype/ttf-dejavu XMLPARSER=libxml2 DESTDIR=$(CURDIR)/debian/tmp PREFIX=/usr LIB_DIR_NAME=/mapnik/0.7
+SCONS_FLAGS := INPUT_PLUGINS=raster,sqlite,postgis,ogr,shape,osm,gdal,kismet
+SCONS_FLAGS += PROJ_INCLUDES=/usr/include PROJ_LIBS=/usr/lib
+SCONS_FLAGS += SYSTEM_FONTS=/usr/share/fonts/truetype/ttf-dejavu
+SCONS_FLAGS += XMLPARSER=libxml2
+SCONS_FLAGS += DESTDIR=$(CURDIR)/debian/tmp
+SCONS_FLAGS += PREFIX=/usr LIB_DIR_NAME=/mapnik/0.7
 
 CFLAGS = -Wall -g
 

Attachment: signature.asc
Description: PGP signature


Reply to: