[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#600960: marked as done (britney2: tpu binNMU handling appears to be broken)

Your message dated Thu, 28 Oct 2010 22:57:37 +0100
with message-id <1288303058.18258.1647.camel@hathi.jungle.funky-badger.org>
and subject line Re: Bug#600960: britney2: binNMU handling appears to be broken
has caused the Debian Bug report #600960,
regarding britney2: tpu binNMU handling appears to be broken
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
600960: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=600960
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
User: release.debian.org@packages.debian.org
Usertag: britney
Severity: important

[Filing for documentation, partly so I don't keep forgetting to look at
this]

b2's handling of binNMUs seems to contain some regressions relative to
b1's.

Recent diffs of the b1 and b2 results have shown that:

- b2 will accept binNMUs which increase installability
- despite having claimed to have accepted binNMUs during the run, b2
includes the original package version in the Heidi result

Adam

--- End Message ---
--- Begin Message --- 
On Thu, 2010-10-28 at 20:08 +0100, Adam D. Barratt wrote:
> On Thu, 2010-10-21 at 21:19 +0100, Adam D. Barratt wrote:
> > b2's handling of binNMUs seems to contain some regressions relative to
> > b1's.
[...]
> Some experimentation indicates that both of these problems seem to be
> specific to binNMUs in t-p-u.
> 
> Each of these tests added an entry (or modified the existing one) for
> cpu_1.4.3-11.2+b1 to the mips Packages file; all other data was taken
> from the most recent live b2 run:
> 
> - unstable: binNMU migrates and appears in Heidi
> - unstable with an added dependency on libmadeup: binNMU fails to
> migrate during the main run as it would be uninstallable
> - tpu: binNMU migrates during the main run but does not appear in Heidi
> - tpu with added libmadeup dependency: binNMU migrates during the main
> run but does not appear in Heidi

This should now be fixed.  Patch attached for the curious.

Adam

commit 19a7792982dadc4a2c0ed2011a16f204ab3d3f96
Author: Adam D. Barratt <adam@adam-barratt.org.uk>
Date:   Thu Oct 28 19:40:38 2010 +0000

    Correctly handle binNMUs in t-p-u
    
    Signed-off-by: Adam D. Barratt <adam@adam-barratt.org.uk>
    
    "${pkg}/${arch}_tpu" means "the tpu binary packages for $pkg on
    architecture $arch", not "the unstable binary packages for $pkg on
    architecture ${arch}_tpu"

diff --git a/britney.py b/britney.py
index fa71086..7e31c90 100755
--- a/britney.py
+++ b/britney.py
@@ -2001,7 +2001,9 @@ class Britney:
         # arch = "<source>/<arch>",
         elif "/" in pkg:
             pkg_name, arch = pkg.split("/")
-            suite = "unstable"
+            if arch.endswith("_tpu"):
+                arch, suite = arch.split("_")
+            else: suite = "unstable"
         # removal of source packages = "-<source>",
         elif pkg[0] == "-":
             pkg_name = pkg[1:]

--- End Message ---
Reply to: