[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#601541: Permission to upload expect 5.44.1.15-4



Package: release.debian.org
Severity: normal

Hi!

I'd like to upload an expect package with patch that fixes a segfault.

The bug was reported to Ubuntu and to comp.lang.tcl Usenet group.
See http://groups.google.com/group/comp.lang.tcl/browse_thread/thread/8ea4b666c2f31cac#
and https://bugs.launchpad.net/ubuntu/+source/expect/+bug/608343
and https://sourceforge.net/tracker/index.php?func=detail&aid=3095935&group_id=13179&atid=313179

The patch is one-liner, debdiff with 5.44.1.15-3 is attached.

-- System Information:
Debian Release: 5.0.6
  APT prefers stable
  APT policy: (990, 'stable'), (500, 'unstable')
Architecture: i386 (x86_64)

Kernel: Linux 2.6.32-3-amd64 (SMP w/8 CPU cores)
Locale: LANG=ru_RU.CP1251, LC_CTYPE=ru_RU.CP1251 (charmap=CP1251)
Shell: /bin/sh linked to /bin/bash
diff -u expect-5.44.1.15/debian/changelog expect-5.44.1.15/debian/changelog
--- expect-5.44.1.15/debian/changelog
+++ expect-5.44.1.15/debian/changelog
@@ -1,3 +1,10 @@
+expect (5.44.1.15-4) unstable; urgency=low
+
+  * Added patch by upstream which fixes crash during exact string matching
+    in expect command if the search pattern contains non-ASCII characters.
+
+ -- Sergei Golovan <sgolovan@debian.org>  Wed, 27 Oct 2010 10:29:04 +0400
+
 expect (5.44.1.15-3) unstable; urgency=low
 
   * Added patch by upstream (proposed by Per Cederqvist) which fixes
diff -u expect-5.44.1.15/debian/patches/series expect-5.44.1.15/debian/patches/series
--- expect-5.44.1.15/debian/patches/series
+++ expect-5.44.1.15/debian/patches/series
@@ -17,0 +18 @@
+21-match.patch
only in patch2:
unchanged:
--- expect-5.44.1.15.orig/debian/patches/21-match.patch
+++ expect-5.44.1.15/debian/patches/21-match.patch
@@ -0,0 +1,17 @@
+Author: Upstream
+Description: Patch fixes segfault for matching exact string with
+ non-ASCII characters in it.
+Bug: https://sourceforge.net/tracker/?func=detail&aid=3095935&group_id=13179&atid=313179
+
+--- expect-5.44.1.15.orig/expect.c
++++ expect-5.44.1.15/expect.c
+@@ -946,6 +946,9 @@
+ 	expDiagLogU(expPrintify(Tcl_GetString(e->pat)));
+ 	expDiagLog("\"? ");
+ 	if (p) {
++	    /* Bug 3095935. Go from #bytes to #chars */
++	    patLength = Tcl_NumUtfChars (pat, patLength);
++
+ 	    e->simple_start = p - str;
+ 	    o->e = e;
+ 	    o->matchlen = patLength;

Reply to: