[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#601414: Future freeze exception for liburi-perl



Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: freeze-exception

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi,

liburi-perl has been bitten by a FTBFS bug: #601116

The bug affects 1.54-1 in testing and 1.55-1 in unstable (but not the
new 1.56 release).

While looking at the issue I found a simple solution to fix the bug:
touch a file before running the test suite, so the failing test
(which needs DNS) is skipped. (More details in #601116.)

My proposal is to add this fix to the current 1.54-1 version and
upload it as 1.54-2 to t-p-u. (Alternatives like backporting the
changes from 1.56 to 1.54 or accepting 1.56 for testing are probably
more error prone and for sure more work both to create and to
review).

The complete debdiff would look like:

#v+
diff -Nru liburi-perl-1.54/debian/changelog liburi-perl-1.54/debian/changelog
- --- liburi-perl-1.54/debian/changelog   2010-04-01 22:12:40.000000000 +0200
+++ liburi-perl-1.54/debian/changelog   2010-10-23 18:13:51.000000000 +0200
@@ -1,3 +1,9 @@
+liburi-perl (1.54-2) UNRELEASED; urgency=low
+
+  * Don't run online tests (closes: #601116).
+
+ -- gregor herrmann <gregoa@debian.org>  Sat, 23 Oct 2010 18:13:39 +0200
+
 liburi-perl (1.54-1) unstable; urgency=low
 
   * New upstream release.
diff -Nru liburi-perl-1.54/debian/control liburi-perl-1.54/debian/control
- --- liburi-perl-1.54/debian/control     2010-04-01 22:11:18.000000000 +0200
+++ liburi-perl-1.54/debian/control     2010-10-23 18:14:36.000000000 +0200
@@ -1,7 +1,7 @@
 Source: liburi-perl
 Section: perl
 Priority: optional
- -Build-Depends: debhelper (>= 7)
+Build-Depends: debhelper (>= 7.0.50~)
 Build-Depends-Indep: perl, libbusiness-isbn-perl
 Maintainer: Debian Perl Group <pkg-perl-maintainers@lists.alioth.debian.org>
 Uploaders: Stefan Hornburg (Racke) <racke@linuxia.de>,
diff -Nru liburi-perl-1.54/debian/rules liburi-perl-1.54/debian/rules
- --- liburi-perl-1.54/debian/rules       2010-03-15 16:38:38.000000000 +0100
+++ liburi-perl-1.54/debian/rules       2010-10-23 18:14:17.000000000 +0200
@@ -2,3 +2,8 @@
 
 %:
        dh $@
+
+override_dh_auto_test:
+       touch OFFLINE
+       dh_auto_test
+       $(RM) OFFLINE
#v-


Does this sound acceptable?

Cheers,
gregor

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQIcBAEBCAAGBQJMxfCKAAoJELs6aAGGSaoGxXIP/RWH2ZAhdNu90qbj8JpuRo/4
12ndAwX0SuEKg0yw1ZU91TfrSnzLsFtlhkaW2h7uiPwc6LhRVRaRuPc6A2bEpnJv
5zDa/PiDtpMqmmwrPnaoWXaT5BJU9j9QzLlPDrsN11CebcmIy3JdHk6e49Bo2m+/
ByLUZ/Uezjke4CVPxBb7AMwwXTksMqx3VfMgHbzGxcVpK4XR+0CcBiBGDFDPazyD
lz2U00G+MQwiXcpL9Ht6vc492ahdF7INe3o4il8yF/Roog0klK9r4fVvjcTUzShi
sri7t/oQPXnDE677sCrJYcY3QTbNXKksB8HKY4H5RShtA9J/KbinkDz7t7NpfzmO
e5Asb/LuZrIYlBkLEc82E7/2lD3oYcHxxL7rN+CWGmFPrzLvo4wovf16zJrG2WxO
YZKOqKB+PnHieCFUjmkzG2PU1dcweJ2srK0N0FuS9086k+WdDsUm1CVYb5LQ3BG/
GX6jMEIpFhZIL6oGJ3TKhxkOh5S9sG5nO+DinOVkKwsm8ALDd3BJRPD/6JlukujV
tEKhX0y111NwOMHgYF7tfphfzj7XgIFWWu3zU0SiEUqGW1m5MaZR7RpaJPwDNsyw
e/1bBellLl52lYyLg4TQoJiRhJ3dNJVke1t8/g3Mq305GlhrMTPtqLkwTPkL8JOU
FYAB3Vqi8sku0y/9rOqp
=N3WV
-----END PGP SIGNATURE-----



Reply to: