[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#600465: unblock: freeradius 2.1.10+dfsg-1

Josip Rodin wrote:
> [For Alan: I requested for FreeRADIUS 2.1.10 to replace 2.1.9 in the future
> Debian 6.0 release; the former came too late in our process to be accepted
> automatically.]


>> This, from main/events.c, looks obviously wrong, however:
>> +       home->zombie_period_start.tv_sec = home->last_packet;
>> +       home->zombie_period_start.tv_sec = USEC / 2;
>> Presumably the second tv_sec should be tv_usec.

  Yes, ouch.

> Yeah, that sounds like it to me, too. That change came in this commit
> http://github.com/alandekok/freeradius-server/commit/f8bcc0fe
> which actually probably fixed a fatal crash (the assert call removed
> because "Don't check home->ev due to race conditions."), so that's still
> probably better than one randomized zombie period start (which can
> get reset and/or ignored soon enough anyway) which is why nobody else
> noticed.
> Alan, is this correct?

  Yes.  I'll commit a fix.

  Alan DeKok.

Reply to: