[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#600145: marked as done (freeze exception: openarena/0.8.5-5)

Your message dated Wed, 20 Oct 2010 22:23:26 +0100
with message-id <1287609806.28575.1059.camel@hathi.jungle.funky-badger.org>
and subject line Re: Bug#600145: freeze exception: openarena/0.8.5-5
has caused the Debian Bug report #600145,
regarding freeze exception: openarena/0.8.5-5
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
600145: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=600145
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: freeze-exception

Please consider unblocking openarena 0.8.5-5, which fixes a reasonably common
server crash with a one-line patch. I don't think it's RC, but it'd be
an unfortunate bug to have in stable.

unblock openarena/0.8.5-5

openarena (0.8.5-5) unstable; urgency=medium

  * Add patch (already upstream as oax r239) to fix a crash if a non-client
    object is damaged by a non-player source, e.g. setting off the Kamikaze
    near a powerup (Closes: #599866)

 -- Simon McVittie <smcv@debian.org>  Mon, 11 Oct 2010 19:40:30 +0100

The patch itself just adds a NULL pointer check (below). In upstream openarena
the bug is masked by the virtual machine, in which memory addresses just
wrap around, but we're using native code in Debian for DFSG reasons.

Regards,
    S

--- a/game/code/game/g_combat.c
+++ b/game/code/game/g_combat.c
@@ -1043,7 +1043,7 @@ void G_Damage( gentity_t *targ, gentity_t *inflictor, gentity_t *attacker,
         
         //Sago: See if the client was sent flying
         //Check if damage is by somebody who is not a player!
-        if( (!attacker || attacker->s.eType != ET_PLAYER) && client->lastSentFlying>-1 && ( mod==MOD_FALLING || mod==MOD_LAVA || mod==MOD_SLIME || mod==MOD_TRIGGER_HURT || mod==MOD_SUICIDE) )  {
+        if( (!attacker || attacker->s.eType != ET_PLAYER) && client && client->lastSentFlying>-1 && ( mod==MOD_FALLING || mod==MOD_LAVA || mod==MOD_SLIME || mod==MOD_TRIGGER_HURT || mod==MOD_SUICIDE) )  {
             if( client->lastSentFlyingTime+5000<level.time) {
                 client->lastSentFlying = -1; //More than 5 seconds, not a kill!
             } else {

Attachment: signature.asc
Description: Digital signature


--- End Message ---
--- Begin Message --- 
On Wed, 2010-10-13 at 23:11 +0100, Simon McVittie wrote:
> Please consider unblocking openarena 0.8.5-5, which fixes a reasonably common
> server crash with a one-line patch. I don't think it's RC, but it'd be
> an unfortunate bug to have in stable.
[...]
> The patch itself just adds a NULL pointer check (below). In upstream openarena
> the bug is masked by the virtual machine, in which memory addresses just
> wrap around, but we're using native code in Debian for DFSG reasons.

Unblocked.

Regards,

Adam

--- End Message ---
Reply to: