--- Begin Message ---
- To: Debian Bug Tracking System <submit@bugs.debian.org>
- Subject: future unblock: libtime-progress-perl/1.6-1
- From: Salvatore Bonaccorso <salvatore.bonaccorso@gmail.com>
- Date: Thu, 09 Sep 2010 18:55:21 +0200
- Message-id: <20100909165521.3581.7314.reportbug@elende.valinor.li>
Package: release.debian.org
Severity: wishlist
User: release.debian.org@packages.debian.org
Usertags: unblock
Dear Release Team
I have set the Severity to wishlist, as this upload will not fix a but
>= important, but it has somehow to do with documentation fix. 1.5 had
a discrepancy between implemented function name and what the manpage
stated. See
https://rt.cpan.org/Public/Bug/Display.html?id=58127
This was fixed in 1.6 of Time::Progress. I prepared a new upstream
version to upload to unstable, and would like to ask if it would be
possible to have this unblocked. Here is the diffstat between 1.5-1
and the prepared 1.6-1:
Changes | 4 ++
META.yml | 6 ++-
Progress.pm | 22 +++++++-----
debian/changelog | 18 +++++++++
debian/control | 4 +-
debian/copyright | 38 ++++++++++-----------
debian/patches/fix-spelling-error-in-manpage.patch | 18 +++++++++
debian/patches/series | 1
debian/rules | 21 -----------
debian/source/format | 1
test.pl | 17 ---------
11 files changed, 81 insertions(+), 69 deletions(-)
Attached is the debdiff.
Please unblock package libtime-progress-perl if possible.
unblock libtime-progress-perl/1.6-1
Thanks in advance,
Bests
Salvatore
-- System Information:
Debian Release: squeeze/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.26-2-amd64 (SMP w/8 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/dash
diff -Nru libtime-progress-perl-1.5/Changes libtime-progress-perl-1.6/Changes
--- libtime-progress-perl-1.5/Changes 2009-02-06 23:04:51.000000000 +0100
+++ libtime-progress-perl-1.6/Changes 2010-09-08 22:27:45.000000000 +0200
@@ -1,5 +1,9 @@
Revision history for Perl extension Time::Progress.
+1.6 Wed Sep 8 2010
+
+ - fixed helpers (note by Andreas Koenig)
+
1.5 Wed Feb 6 2009
- %LlEe formats can take optional width (%10e for example)
diff -Nru libtime-progress-perl-1.5/META.yml libtime-progress-perl-1.6/META.yml
--- libtime-progress-perl-1.5/META.yml 2009-02-06 23:05:29.000000000 +0100
+++ libtime-progress-perl-1.6/META.yml 2010-09-08 22:28:00.000000000 +0200
@@ -1,6 +1,6 @@
--- #YAML:1.0
name: Time-Progress
-version: 1.5
+version: 1.6
abstract: Elapsed and estimated finish time reporting.
author:
- Vladi Belperchinov-Shabanski <cade@biscom.net>
@@ -8,12 +8,14 @@
distribution_type: module
configure_requires:
ExtUtils::MakeMaker: 0
+build_requires:
+ ExtUtils::MakeMaker: 0
requires: {}
no_index:
directory:
- t
- inc
-generated_by: ExtUtils::MakeMaker version 6.48
+generated_by: ExtUtils::MakeMaker version 6.56
meta-spec:
url: http://module-build.sourceforge.net/META-spec-v1.4.html
version: 1.4
diff -Nru libtime-progress-perl-1.5/Progress.pm libtime-progress-perl-1.6/Progress.pm
--- libtime-progress-perl-1.5/Progress.pm 2009-02-06 23:04:43.000000000 +0100
+++ libtime-progress-perl-1.6/Progress.pm 2010-09-08 22:05:33.000000000 +0200
@@ -2,7 +2,7 @@
use Exporter;
our @ISA = qw( Exporter );
our @EXPORT = qw( );
-our $VERSION = '1.5';
+our $VERSION = '1.6';
use strict;
use warnings;
use Carp;
@@ -143,16 +143,16 @@
}
sub elapsed
-{ my $self = shift; return $self->report("%l"); }
+{ my $self = shift; return $self->report("%l",@_); }
sub elapsed_str
-{ my $self = shift; return $self->report("elapsed time is %L min.\n"); }
+{ my $self = shift; return $self->report("elapsed time is %L min.\n",@_); }
sub estimate
-{ my $self = shift; return $self->report("%e"); }
+{ my $self = shift; return $self->report("%e",@_); }
sub estimate_str
-{ my $self = shift; return $self->report("remaining time is %E min.\n"); }
+{ my $self = shift; return $self->report("remaining time is %E min.\n",@_); }
1;
@@ -283,7 +283,7 @@
=item report
-B<report> is the most complex method in this package! :)
+B<report> is the most complex method in this package. :)
expected arguments are:
@@ -356,17 +356,21 @@
=item elapsed
-=item estimated
+=item estimate
+
+helpers -- return elapsed/estimate seconds.
=item elapsed_str
-=item estimated_str
+=item estimate_str
-helpers -- return elapsed/estimated seconds or string in format:
+helpers -- return elapsed/estimated string in format:
"elapsed time is MM:SS min.\n"
"remaining time is MM:SS min.\n"
+all helpers need one argument--current item.
+
=back
=head1 FORMAT EXAMPLES
diff -Nru libtime-progress-perl-1.5/debian/changelog libtime-progress-perl-1.6/debian/changelog
--- libtime-progress-perl-1.5/debian/changelog 2010-09-09 18:41:49.000000000 +0200
+++ libtime-progress-perl-1.6/debian/changelog 2010-09-09 18:31:18.000000000 +0200
@@ -1,3 +1,21 @@
+libtime-progress-perl (1.6-1) unstable; urgency=low
+
+ * Team upload.
+ * New upstream release
+ * debian/control: Changed: Replace versioned (build-)dependency on
+ perl (>= 5.6.0-{12,16}) with an unversioned dependency on perl (as
+ permitted by Debian Policy 3.8.3).
+ * debian/rules: Simplify to a three line rules file.
+ * Convert to '3.0 (quilt)' source package format.
+ * Refresh debian/copyright file: Use revision 135 of format-
+ specification in DEP5 for machine-readable copyright file
+ information.
+ * Bump Standards-Version to 3.9.1.
+ * Add fix-spelling-error-in-manpage.patch to fix a small spelling
+ error in manpage.
+
+ -- Salvatore Bonaccorso <salvatore.bonaccorso@gmail.com> Thu, 09 Sep 2010 18:31:14 +0200
+
libtime-progress-perl (1.5-1) unstable; urgency=low
* Initial Release. (closes: #535137) (LP: #318626)
diff -Nru libtime-progress-perl-1.5/debian/control libtime-progress-perl-1.6/debian/control
--- libtime-progress-perl-1.5/debian/control 2010-09-09 18:41:49.000000000 +0200
+++ libtime-progress-perl-1.6/debian/control 2010-09-09 16:03:59.000000000 +0200
@@ -2,10 +2,10 @@
Section: perl
Priority: optional
Build-Depends: debhelper (>= 7)
-Build-Depends-Indep: perl (>= 5.6.0-12)
+Build-Depends-Indep: perl
Maintainer: Debian Perl Group <pkg-perl-maintainers@lists.alioth.debian.org>
Uploaders: Nathan Handler <nhandler@ubuntu.com>
-Standards-Version: 3.8.2
+Standards-Version: 3.9.1
Homepage: http://search.cpan.org/dist/Time-Progress/
Vcs-Svn: svn://svn.debian.org/pkg-perl/trunk/libtime-progress-perl/
Vcs-Browser: http://svn.debian.org/viewsvn/pkg-perl/trunk/libtime-progress-perl/
diff -Nru libtime-progress-perl-1.5/debian/copyright libtime-progress-perl-1.6/debian/copyright
--- libtime-progress-perl-1.5/debian/copyright 2010-09-09 18:41:49.000000000 +0200
+++ libtime-progress-perl-1.6/debian/copyright 2010-09-09 16:03:48.000000000 +0200
@@ -1,29 +1,29 @@
-Format-Specification:
- http://wiki.debian.org/Proposals/CopyrightFormat?action=recall&rev=196
-Upstream-Maintainer: Vladi Belperchinov-Shabanski <cade@biscom.net>
-Upstream-Source: http://search.cpan.org/dist/Time-Progress/
-Upstream-Name: Time-Progress
+Format-Specification: http://svn.debian.org/wsvn/dep/web/deps/dep5.mdwn?op=file&rev=135
+Maintainer: Vladi Belperchinov-Shabanski <cade@biscom.net>
+Source: http://search.cpan.org/dist/Time-Progress/
+Name: Time-Progress
Files: *
Copyright: 2001-2009, Vladi Belperchinov-Shabanski <cade@biscom.net>
-License-Alias: Perl
-License: Artistic | GPL-1+
+License: Artistic or GPL-1+
Files: debian/*
Copyright: 2009, Nathan Handler <nhandler@ubuntu.com>
-License-Alias: Perl
-License: Artistic | GPL-1+
+ 2010, Salvatore Bonaccorso <salvatore.bonaccorso@gmail.com>
+License: Artistic or GPL-1+
License: Artistic
- This program is free software; you can redistribute it and/or modify
- it under the terms of the Artistic License, which comes with Perl.
- On Debian GNU/Linux systems, the complete text of the Artistic License
- can be found in /usr/share/common-licenses/Artistic
+ This program is free software; you can redistribute it and/or modify
+ it under the terms of the Artistic License, which comes with Perl.
+ .
+ On Debian systems, the complete text of the Artistic License can be
+ found in `/usr/share/common-licenses/Artistic'.
License: GPL-1+
- This program is free software; you can redistribute it and/or modify
- it under the terms of the GNU General Public License as published by
- the Free Software Foundation; either version 1, or (at your option)
- any later version.
- On Debian GNU/Linux systems, the complete text of the GNU General
- Public License can be found in `/usr/share/common-licenses/GPL'
+ This program is free software; you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation; either version 1, or (at your option)
+ any later version.
+ .
+ On Debian systems, the complete text of version 1 of the GNU General
+ Public License can be found in `/usr/share/common-licenses/GPL-1'.
diff -Nru libtime-progress-perl-1.5/debian/patches/fix-spelling-error-in-manpage.patch libtime-progress-perl-1.6/debian/patches/fix-spelling-error-in-manpage.patch
--- libtime-progress-perl-1.5/debian/patches/fix-spelling-error-in-manpage.patch 1970-01-01 01:00:00.000000000 +0100
+++ libtime-progress-perl-1.6/debian/patches/fix-spelling-error-in-manpage.patch 2010-09-09 16:26:13.000000000 +0200
@@ -0,0 +1,18 @@
+Description: Fix spelling error in manpage.
+Origin: vendor
+Bug: https://rt.cpan.org/Public/Bug/Display.html?id=61203
+Forwarded: yes
+Author: Salvatore Bonaccorso <salvatore.bonaccorso@gmail.com>
+Last-Update: 2010-09-09
+
+--- a/Progress.pm
++++ b/Progress.pm
+@@ -225,7 +225,7 @@
+
+ =item stop
+
+-Sets the stop mark. this is only usefull if you do some work, then finish,
++Sets the stop mark. this is only useful if you do some work, then finish,
+ then do some work that shouldn't be timed and finally report. Something
+ like:
+
diff -Nru libtime-progress-perl-1.5/debian/patches/series libtime-progress-perl-1.6/debian/patches/series
--- libtime-progress-perl-1.5/debian/patches/series 1970-01-01 01:00:00.000000000 +0100
+++ libtime-progress-perl-1.6/debian/patches/series 2010-09-09 16:14:03.000000000 +0200
@@ -0,0 +1 @@
+fix-spelling-error-in-manpage.patch
diff -Nru libtime-progress-perl-1.5/debian/rules libtime-progress-perl-1.6/debian/rules
--- libtime-progress-perl-1.5/debian/rules 2010-09-09 18:41:49.000000000 +0200
+++ libtime-progress-perl-1.6/debian/rules 2010-09-09 16:03:48.000000000 +0200
@@ -1,23 +1,4 @@
#!/usr/bin/make -f
-build: build-stamp
-build-stamp:
- dh build
- touch $@
-
-clean:
+%:
dh $@
-
-install: install-stamp
-install-stamp: build-stamp
- dh install
- touch $@
-
-binary-arch:
-
-binary-indep: install
- dh $@
-
-binary: binary-arch binary-indep
-
-.PHONY: binary binary-arch binary-indep install clean build
diff -Nru libtime-progress-perl-1.5/debian/source/format libtime-progress-perl-1.6/debian/source/format
--- libtime-progress-perl-1.5/debian/source/format 1970-01-01 01:00:00.000000000 +0100
+++ libtime-progress-perl-1.6/debian/source/format 2010-09-09 16:03:48.000000000 +0200
@@ -0,0 +1 @@
+3.0 (quilt)
diff -Nru libtime-progress-perl-1.5/test.pl libtime-progress-perl-1.6/test.pl
--- libtime-progress-perl-1.5/test.pl 2008-04-30 01:33:12.000000000 +0200
+++ libtime-progress-perl-1.6/test.pl 1970-01-01 01:00:00.000000000 +0100
@@ -1,17 +0,0 @@
-# Before `make install' is performed this script should be runnable with
-# `make test'. After `make install' it should work as `perl test.pl'
-
-#########################
-
-# change 'tests => 1' to 'tests => last_test_to_print';
-
-use Test;
-BEGIN { plan tests => 1 };
-use Time::Progress;
-ok(1); # If we made it this far, we're ok.
-
-#########################
-
-# Insert your test code below, the Test module is use()ed here so read
-# its man page ( perldoc Test ) for help writing this test script.
-
--- End Message ---
--- Begin Message ---
- To: 596247-done@bugs.debian.org
- Cc: Salvatore Bonaccorso <salvatore.bonaccorso@gmail.com>
- Subject: Re: Bug#596247: future unblock: libtime-progress-perl/1.7-1
- From: "Adam D. Barratt" <adam@adam-barratt.org.uk>
- Date: Sun, 03 Oct 2010 12:04:21 +0100
- Message-id: <1286103861.6044.37.camel@hathi.jungle.funky-badger.org>
- In-reply-to: <1285513703.2993.1500.camel@hathi.jungle.funky-badger.org>
- References: <20100909165521.3581.7314.reportbug@elende.valinor.li> <20100910121048.GA30286@elende> <1285268588.5424.4.camel@hathi.jungle.funky-badger.org> <20100924061108.GA11906@elende> <1285513703.2993.1500.camel@hathi.jungle.funky-badger.org>
On Sun, 2010-09-26 at 16:08 +0100, Adam D. Barratt wrote:
> On Fri, 2010-09-24 at 08:11 +0200, Salvatore Bonaccorso wrote:
> > I agree that these are 'major' packaging changes. I hope I can convice
> > that they are not harmfull ;-). I introduced the change in the source
> > package format in the 1.5 -> 1.6 step, as libtime-progress-perl had no
> > patch before, then added the fix-spelling error. This way, reducing
> > the debian/rules and converting the source package format, we did not
> > need to add quilt to Build-Depends, nor bump Build-Depends on
> > debhelper (>= 7.0.8). The packaging of Perl modules are 'smooth' in
> > general, so even the packaging introduced this major changes, it does
> > not 'break'.
>
> They also make the diff noisier than it needs to be to fix just the
> reported issues and add the potential for introducing issues which
> aren't immediately obvious.
Unblocked.
Regards,
Adam
--- End Message ---