[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Accepted wireshark 1.2.10-2+squeeze1 (source i386)



Hi,

There would be another path to go with wireshark.

Would you like the idea of allowing 1.2.11-2 to go to testing if I fix
the regression introduced by 1.2.11?

Here are the changes introduced in 2.1.11:

0001-1.2.10-1.2.11.patch - changing version
0002-Automatic-manuf-and-enterprise-numbers-update-for-20.patch -
harmless data update
0003-Put-back-some-check_col-s-that-were-mistakenly-remov.patch -
obsolete, reverted in 0003-...
0004-Revert-rev-33697-it-s-not-necessary-check_col-is-NOT.patch -
fixes crash reported in #597703
0005-Trivial-Copy-over-Revision-29205-reassemble.h-update.patch - comment fixes
0006-Trivial-Copy-over-Revision-29397-White-space-changes.patch -
white space changes only
0007-Trivial-Copy-over-Revision-28992-Added-some-casts-fo.patch - two
trivial casts
0008-Copy-over-29066-optimizes-the-data-source-name-proce.patch -
small optimization patch
0009-Copy-over-29427-introduces-packet_add_new_data_sourc.patch -
small optimization patch
0010-Copy-over-29940-Use-the-slice-allocator-if-GLIB-2-10.patch - use
different memory allocator with newer glib, should not cause problems
0011-Automatic-manuf-and-enterprise-numbers-update-for-20.patch  -
harmless data update
0012-Pick-up-change-from-the-trunk.patch - does not affect Debian
0013-Pick-up-change-from-the-trunk.patch - minor SMB dissector improvement
0014-Automatic-manuf-and-enterprise-numbers-update-for-20.patch -
harmless data update
0015-Pick-up-change-from-trunk.patch - fix potential infinite loop in
BOOTP dissector
0016-Automatic-manuf-and-enterprise-numbers-update-for-20.patch -
harmless data update
0017-Copy-over-revisions-by-hand.patch - partially fix DLL hijacking
vulnerability on Windows, should not affect Debian
0018-Forward-port-r33953.patch - more Windows related fixes
0019-Update-the-security-fix-section.patch - documentation update
0020-Copy-over-revisions-from-the-trunk.patch
  - fix crash in RTSP dissector
  - fix crash in ftype-tvbuff.c
  - additional null pointer check and comment update in packet-sdp.c
  - introduces a regression which can be reverted in packet-ip.c
  - libtoolize file updates
  - minor update to the H264 dissector
  - documentation update
0021-Copy-over-r33921-and-33922-by-hand.patch - nmake update, does not
affect Debian
0022-Copy-over-revisions-from-the-trunk.patch - fix crash while
generating PostScript output
0023-WpdPack-4.1.1-4.1.2.patch - Windows related fix, does not affect Debian
0024-Add-a-CVE-ID.patch - documentation update
0025-Automatic-manuf-and-enterprise-numbers-update-for-20.patch -
harmless data update
0026-Build-1.2.11.patch - documentation update
0027-Fix-the-advisory-link.patch - documentation update

I generated the patch series by importing upstream's Subversion
repository to Git.
I also attached the official 1.2.10-1.2.11 patch released by upstream.

Changes:
 wireshark (1.2.11-1) unstable; urgency=high
 .
   * New upstream release 1.2.11
     - release notes:
       http://www.wireshark.org/docs/relnotes/wireshark-1.2.11.html
       (Closes: #597703)
     - security fixes
        - The RTSP dissector could crash. (No assigned CVE number.)
   * [Debconf translation updates]
     - Basque (Iñaki Larrañaga Murgoitio).

Cheers,
Balint

2010/9/28 Bálint Réczey <balint@balintreczey.hu>:
> Hi,
>
> Sorry,  I haven't contacted the Release Team beforehand.
> It seemed to me that contacting them beforehand was optional, but I had to
> contact them approval after the successful builds.
>
> I'll contact them next time before the first upload.
>
> Originally I planned asking for an unblock request for 1.2.11-1, but
> it introduced a
> regression so I backported the important fixes from the diff in
> 1.2.10-2+squeeze1
> instead.
>
> To see the bright side, the backported changes get testing in unstable
> and Daniel's
> part is being tested in Ubuntu.
>
> Cheers,
> Balint
>
> 2010/9/28 Adam D. Barratt <adam@adam-barratt.org.uk>:
>> On Tue, 2010-09-28 at 15:32 +0000, Balint Reczey wrote:
>>>  wireshark (1.2.10-2+squeeze1) testing-proposed-updates; urgency=low
>> [...]
>>>    * Backport changes from 1.2.11
>>>      - Fix segmentation fault (Closes: #597703)
>>>      - Fix inifinite loop in Bootstrap Protocol dissector
>>>      - Fix crash in RTSP dissector
>>>      - Fix crash when filtering packets based on expert info
>>>      - Fix crash when generating PostScript output
>>>    [Daniel T Chen]
>>>    * 22_lp606063-fix-assertion-capture_start.patch:
>>>      Handle event handler being invoked recursively.  Fix backported from
>>>      upstream SVN r33906.  Thanks, Gregor Beck!
>>
>> Was this upload discussed with anyone on the Release Team beforehand?
>>
>> It would have been preferable for these changes to be made via unstable,
>> to give them a chance to be tested before reaching testing.  I see
>> 1.2.11 has now been uploaded to unstable, with a larger diff. :-/
>>
>> Regards,
>>
>> Adam
>>
>>
>

Attachment: wireshark-1.2.10-1.2.11-patches.tar.bz2
Description: BZip2 compressed data

Attachment: patch-wireshark-1.2.10-to-1.2.11.diff.bz2
Description: BZip2 compressed data


Reply to: