On Tue, Sep 28, 2010 at 00:42:08 +0900, Simon Horman wrote: > Hi, > > I would like the upload of 1.17.1-2+lenny2 considered. > My proposed upload resolves the following problems. > > * mysql: Don't store MYSQL * return values in a long > - This seems problematic on architectures such as amd64 where > pointers are 8 bytes wide but long is only 4 bytes wide. > - As per upstream patch > http://hg.vergenet.net/perdition/perdition/rev/db00825e370f long and void * are the same size on all Debian architectures (amd64 has 8-byte longs), so the proposed change is effectively a nop. > * Resolve 4/8 byte problems raised in bug #595432) > - odbc: pass a SQLLEN instead of an SQLINTEGER to SQLBindCol() > + This seems problematic on architectures such as amd64 where > size_t (SQLLEN) is 8 bytes wide but int (SQLINTEGER) is only > 4 bytes wide. > + As per upstream patch > http://hg.vergenet.net/perdition/perdition/rev/57268f4aaa94 That doesn't seem to be included in your proposed diff. > - core: the return value of callbacks to vanessa_socket_pipe_func() > should be a ssize_t not an int. > + This seems problematic on architectures such as amd64 where > ssize_t is 8 bytes wide but int is only 4 bytes wide. > + As per upstream patch > http://hg.vergenet.net/perdition/perdition/rev/57268f4aaa94 That one looks reasonable. Cheers, Julien
Attachment:
signature.asc
Description: Digital signature