Bug#596247: future unblock: libtime-progress-perl/1.7-1
On Fri, 2010-09-24 at 08:11 +0200, Salvatore Bonaccorso wrote:
> On Thu, Sep 23, 2010 at 08:03:08PM +0100, Adam D. Barratt wrote:
> > + * Convert to '3.0 (quilt)' source package format.
[...]
> > + * debian/rules: Simplify to a three line rules file.
[...]
> I agree that these are 'major' packaging changes. I hope I can convice
> that they are not harmfull ;-). I introduced the change in the source
> package format in the 1.5 -> 1.6 step, as libtime-progress-perl had no
> patch before, then added the fix-spelling error. This way, reducing
> the debian/rules and converting the source package format, we did not
> need to add quilt to Build-Depends, nor bump Build-Depends on
> debhelper (>= 7.0.8). The packaging of Perl modules are 'smooth' in
> general, so even the packaging introduced this major changes, it does
> not 'break'.
They also make the diff noisier than it needs to be to fix just the
reported issues and add the potential for introducing issues which
aren't immediately obvious.
> > +helpers -- return elapsed/estimate seconds.
> >
> > s/estimate/&d/
>
> I assume the point here from upstream author was more, to 'align' the
> documentation to the really implemented method name.
[...]
> and indeed in the code, they are implemented with that name:
Yep. That doesn't mean it makes sense as an sentence though. :-)
One other thing I forgot to mention last time - was the removal of
test.pl an upstream change? I realise it wasn't much of a test suite,
but...
Regards,
Adam
Reply to: