[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Unblock xserver-xorg-video-geode

2010/9/18 Martin-Éric Racine <q-funk@iki.fi>:
> 2010/9/3 Martin-Éric Racine <q-funk@iki.fi>:
>> On Fri, Sep 3, 2010 at 11:46 AM, Julien Cristau <jcristau@debian.org> wrote:
>>> On Fri, Sep  3, 2010 at 09:33:19 +0800, Huang, FrankR wrote:
>>>>       I saw this thread from top to the end.
>>>>       Is it because the patch
>>>>               http://cgit.freedesktop.org/xorg/driver/xf86-video-geode/commit/?id=e9447f5335681a78cf87ebf8c9659a6fecfc9746
>>>>       block the geode driver to be accepted?
>>>>       If that is so, can we agree with the suggestion from Julien?
>>>>               if ((pGeode->Output & (OUTPUT_PANEL | OUTPUT_DCON)) ==
>>>>               (OUTPUT_PANEL | OUTPUT_DCON))
>>> Well, or you could make it if (pGeode->Output == (OUTPUT_PANEL |
>>> OUTPUT_DCON)).  Or alternatively, explain why the existing code is
>>> correct.
>> We'll discuss this particular one with Otavio and let him comment on
>> the solution.
> Otavio, we're still waiting for your explanation on this issue.

Andres Salomon submitted a simple fix for this issue. Basically, we no
longer check the panel bit. Instead, we only check if we're running on
DCON-equipped hardware to make an exact match for the OLPC XO-1
configuration which, if found, will set the display to the XO-1's
unique resolution. This has been committed upstream and could be added
to the current 2.11.9 package as a patch and pushed as 2.11.9-3.

Is there any other issue left to address, before this unblock request
can be approved?

Best Regards,

Reply to: