Le samedi 11 septembre 2010 à 19:26 +0200, Julien Cristau a écrit : > +++ epiphany-browser-2.30.5/data/epiphany-2.29.pc 2010-08-30 22:55:34.000000000 +0000 > > that file shouldn't be in the tarball. I can confirm that it is correctly regenerated during the build, so this is harmless (although a bug indeed). > +++ epiphany-browser-2.30.5/data/org.gnome.Epiphany.service 2010-08-30 22:58:52.000000000 +0000 > > same. Ditto. > + cd debian/epiphany-browser-data/usr/share/applications/ \ > + && mv epiphany.desktop epiphany-browser.desktop > > is this what made epiphany disappear from my panel? Most probably. > any way we can avoid that? We could by shipping two desktop files, with one of them having NoDisplay=true added. Do you want me to add this change? I’m afraid it’s the kind of thing we will have to keep forever if we do. > [ignoring doc/reference/ changes] > > + gboolean inspector_attached; > guint is_setting_zoom : 1; > > kind of weird to be mixing Booleans as gboolean and as 1-bit bitfield. I agree using the bitfield is a bug, but it predates this change. > gtk_window_set_default_size (GTK_WINDOW (embed->priv->inspector_window), > - 600, 400); > + 800, 600); > > Not quite convinced... 600 pixels high on a netbook means part of it > will be off-screen, if you take into account the panel and window > decorations? Why is the size static anyway... Apparently the contents don’t fit in a 400 pixels window: https://bugzilla.gnome.org/show_bug.cgi?id=626625 As for the default size being static, it is generally necessary for windows that have a large area for which you cannot compute the size. Which is precisely the case of the inspector, which is not even made of GTK+ widgets. > There's a changelog entry saying 'use cairo_fill instead of > cairo_paint', yet lib/widgets/ephy-spinner.c replaced gdk_draw_pixbuf > with cairo_paint? The changelog entry you are referring to is fixing a typo. The large change was named: “use cairo for drawing widgets”. > + Split EphyNavigationAction in one abstract class and two subclasses > > that one is pretty huge, I won't be reviewing this part. Do you want me to revert this commit? Note that it fixes a real bug: https://bugzilla.gnome.org/show_bug.cgi?id=539716 -- .''`. Josselin Mouette : :' : `. `' “If you behave this way because you are blackmailed by someone, `- […] I will see what I can do for you.” -- Jörg Schilling
Attachment:
signature.asc
Description: This is a digitally signed message part