Re: Bug #595344: Please unblock php-xml-serializer (was: Fixing issues in php-xml-serializer)
Thomas Goirand wrote:
> Hi team,
>
> I've been trying to fix issues in php-xml-serializer. I think I managed
> to fix the PHP 5.3 deprecation issue, however, after my last upload to
> SID, I realized that there was still quite some issues in it, noticeably
> that the package is still sending some docs in
> /usr/share/php/{docs,tests}, which potentially could lead to upgrade
> issues (like I just fixed for php-mail-mime in SID, for which I will ask
> for another unblock).
>
> It would have been an easy fix, if the package wasn't using CDBS that I
> quite dislike. Why isn't the CDBS "magic" fixing the issue by itself?
CDBS really did the expected "magic": I was plain wrong. In fact, I was
surprised that it did *symlinks* in /usr/share/php/{docs,tests} and the
content really is in the correct /usr/share/doc/php-xml-serializer
folder as one would expect.
As a consequence, I think that the package is in good shape, and I would
like to ask for an unblock. Changelog is:
* Non-maintainer upload.
* Fixed some "return as new is deprecated" warnings (Closes: #595344).
* Now depends on dpatch as I'm adding a dpatch patch.
* Added a debian/source/format.
* Added a new debian/README.source
* Bumped Standard-Version.
I'm now aware that I shouldn't have done the last 3 things of this
changelog, however, it's already done, and Mehdi wrote to me previously
that it wasn't necessary to undo.
Sorry I didn't look properly, and bothers everyone for no valid reasons.
Cheers,
Thomas
Reply to: