[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#596096: marked as done (unblock: gdm/2.20.11-2)

Your message dated Thu, 9 Sep 2010 17:40:52 +0200
with message-id <20100909154052.GN2676@radis.liafa.jussieu.fr>
and subject line Re: Bug#596096: unblock: gdm/2.20.11-2
has caused the Debian Bug report #596096,
regarding unblock: gdm/2.20.11-2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
596096: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=596096
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: freeze-exception

Please unblock gdm for squeeze.

gdm (2.20.11-2) unstable; urgency=low
 .
   * Use linux-any wildcard instead of listing non-linux architectures.
   * Bump standards version accordingly.
   * 23_xsession-errors.patch: disable the obnoxious behavior that stops
     filling .xsession-errors when there is too much output.
   * Update watch file.

It’s only one simple code change that I’m attaching, and I saw enough
people complain of that behavior to think it’s worth it, even without a
bug report on its own.

Thanks,
-- 
 .''`.
: :' :     “You would need to ask a lawyer if you don't know
`. `'       that a handshake of course makes a valid contract.”
  `-        --  J???rg Schilling

Index: gdm-2.20.11/daemon/slave.c
===================================================================
--- gdm-2.20.11.orig/daemon/slave.c	2010-07-04 15:16:55.919565088 +0200
+++ gdm-2.20.11/daemon/slave.c	2010-07-04 15:17:11.559565073 +0200
@@ -373,10 +373,6 @@ run_session_output (gboolean read_until_
 			break;
 		}
 
-		if G_UNLIKELY (d->xsession_errors_bytes >= MAX_XSESSION_ERRORS_BYTES ||
-			       got_xfsz_signal)
-			continue;
-
 		/* write until we succeed in writing something */
 		VE_IGNORE_EINTR (written = write (d->xsession_errors_fd, buf, r));
 		if G_UNLIKELY (written < 0 || got_xfsz_signal) {
@@ -397,13 +393,6 @@ run_session_output (gboolean read_until_
 
 		d->xsession_errors_bytes += r;
 
-		if G_UNLIKELY (d->xsession_errors_bytes >= MAX_XSESSION_ERRORS_BYTES &&
-			       ! got_xfsz_signal) {
-			VE_IGNORE_EINTR (write (d->xsession_errors_fd,
-						"\n...Too much output, ignoring rest...\n",
-						strlen ("\n...Too much output, ignoring rest...\n")));
-		}
-
 		/* there wasn't more then buf available, so no need to try reading
 		 * again, unless we really want to */
 		if (r < sizeof (buf) && ! read_until_eof)

--- End Message ---
--- Begin Message --- 
On Wed, Sep  8, 2010 at 18:25:20 +0200, Josselin Mouette wrote:

> gdm (2.20.11-2) unstable; urgency=low

Unblocked.
> 
> It’s only one simple code change that I’m attaching, and I saw enough
> people complain of that behavior to think it’s worth it, even without a
> bug report on its own.
> 
Hell yeah, thanks for this...

Cheers,
Julien

Attachment: signature.asc
Description: Digital signature


--- End Message ---
Reply to: