[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Permission to upload bugfix/translation updates for remmina stack

On Wed, Sep  1, 2010 at 22:39:26 +0200, Luca Falavigna wrote:

> Hi,
> I ask permission to upload to unstable (and to be granted subsequent
> unblocks) for the following packages:
> * remmina_0.8.2-1

+#define _FILE_OFFSET_BITS 64

eww.  autoconf has AC_SYS_LARGEFILE, and there's getconf LFS_CFLAGS if you don't want that.

-    if (client->thread) pthread_join (client->thread, NULL);
+    while (client->thread)
+    {
+        gdk_threads_leave ();
+        sleep (1);
+        gdk_threads_enter ();
+    }

what's the reasoning for this one?

Also it seems src/remminaftpclient.c (and a few other files) doesn't include
config.h, that's a recipe for impossible debugging later on.

> * remmina-plugins_0.8.3-1

Not quite sure what this is fixing either, and there's no changelog to

> * remmina-gnome_0.8.1-1


> * remmina-xfce_0.8.1-1


Attachment: signature.asc
Description: Digital signature

Reply to: