Re: Unblock xserver-xorg-video-geode
Hello,
I am adding Martin-Eric to CC so he can address those issues.
On Fri, Aug 27, 2010 at 3:00 PM, Julien Cristau <jcristau@debian.org> wrote:
> On Fri, Aug 27, 2010 at 09:51:39 -0300, Otavio Salvador wrote:
>> Please unblock it since it fixes many critical issues for users.
>>
> -Provides: ${xviddriver:Provides}, xserver-xorg-video-amd
> +Provides: ${xserver:Provides}, xserver-xorg-video-amd
>
> Please add xorg-driver-video to Provides.
Agreed.
> I don't understand the change to lx_crtc_gamma_set.
This was a fix for gnome-screensaver.
Change: 2bcbc0b64091218d348ad9f699370e4bfde3948b
> I can't review most of the EXA changes, but hey, what could possibly go
> wrong...
>
> + /* DCON Panel specific resolution - OLPC's one */
> + if (pGeode->Output & (OUTPUT_PANEL | OUTPUT_DCON)) {
>
> The check kind of disagrees with the comment, this will match for an
> OUTPUT_PANEL with isn't OUTPUT_DCON.
This matches the panels used in OLPC machines. It is the flag seted in
LXPreInit (lx_driver.c). It looks OK for me.
Cheers,
--
Otavio Salvador O.S. Systems
E-mail: otavio@ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
Reply to: