Re: wesnoth-1.8 freeze exception
Hi!
* Julien Cristau <jcristau@debian.org> [2010-08-18 15:37:27 CEST]:
> On Wed, Aug 18, 2010 at 13:48:50 +0200, Gerfried Fuchs wrote:
> > * Julien Cristau <jcristau@debian.org> [2010-08-18 13:26:28 CEST]:
> > > On Tue, Aug 17, 2010 at 09:56:59 +0200, Gerfried Fuchs wrote:
> > > Few questions:
> > >
> > > $BRANODOT isn't used anywhere.
> >
> > It is, in the debian/wesnoth-BRANCH-core.postinst.in file from which
> > this helper script generates debian/wesnoth-1.8-core.postinst
> >
> > #v+
> > update-alternatives --install /usr/games/wesnoth wesnoth \
> > /usr/games/wesnoth-BRANCH BRANODOT \
> > $slaves
> > #v-
> >
> > Given that the branches are increasing its version constantly I chose
> > to use that for calculating the priority for the alternative handling.
>
> But this script replaces BRANODOT with $BRANCH, not $BRANODOT.
Second DOH, you're right, that's clearly a bug in the script. Though,
the file in the source does contain the correct value and the script
isn't called automatically (and wouldn't do anything when called in the
source right now anyway because the branch version is still the same) -
it wouldn't affect the release right now. :)
> [...]
> > I have two or three more things pending that I'd like to push in with
> > the next update fixing the package description improvement and fixing
> > the symlink doc dir transition:
> >
> > -) The wesnoth server package should ship an default file for the
> > init.d script with documentation. It will only contain comments so I
> > don't see an objection here.
> >
> > -) Adding a debian/NEWS entry about the transition and how people are
> > able to keep their old wesnoth version side-by-side with this update to
> > be able to continue to play their already started campaigns.
>
> Sounds ok.
Thanks.
> > -) And this is the thing I would like to see your comments about:
> > Upstream released a 1.8.4 version within the last week. The even minor
> > numbers are their stable releases and they are pretty strict about what
> > they allow into them, they are bound to be compatible with their other
> > stable releases from the branch - and thus they only contain bugfixes
> > and (mostly) translation updates. I wonder if you would be willing to
> > accept that update into squeezes and wether I should base above
> > mentioned changes on that new upstream bugfix release or wether you
> > would want me to base them on the 1.8.3 version and consider 1.8.4 at a
> > later time.
>
> Can we first get 1.8.3 in testing, and then look at 1.8.4?
Sure, definitely - thanks for responding quickly, I'll address your
concerns and get them fixed by hopefully tomorrow, will knock again
then.
Thanks for your outstanding proofreading (and sorry for the need for
it), it's truly appreciated!
Enjoy!
Rhonda
--
"Lediglich 11 Prozent der Arbeitgeber sind der Meinung, dass jeder
Mensch auch ein Privatleben haben sollte."
-- http://www.karriere.at/artikel/884/
Reply to: