[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Ampache Freeze exception



On Mon, 16 Aug 2010 23:15:32 -0500
Charlie Smotherman <cjsmo@cableone.net> wrote:

> Dear Release Team,
> 
> I have prepared a updated version of ampache which fixes RC bugs
> #593181, and #593182.  Attached is a diff of the proposed changes.
> 
> http://mentors.debian.net/debian/pool/main/a/ampache/ampache_3.5.4-7.dsc 
> 
> Best regards
> 
> Charlie Smotherman

-Build-Depends: debhelper (>= 7.0.50), po-debconf
+Build-Depends: debhelper (>= 7.0.50), po-debconf, quilt (>= 0.46-7)
 Standards-Version: 3.9.1
 
 Package: ampache
diff -Nru ampache-3.5.4/debian/patches/debian-changes-3.5.4-7
ampache-3.5.4/debian/patches/debian-changes-3.5.4-7
--- ampache-3.5.4/debian/patches/debian-changes-3.5.4-7
1969-12-31 18:00:00.000000000 -0600 +++
ampache-3.5.4/debian/patches/debian-changes-3.5.4-7	2010-08-16
22:24:38.000000000 -0500 @@ -0,0 +1,390 @@ +Description: Upstream
changes introduced in version 3.5.4-7
+ This patch has been created by dpkg-source during the package build.
+ Here's the last changelog entry, hopefully it gives details on why
+ those changes were made:

You've used dpkg-source to create the patch and then specified quilt as
a Build-Depends? Yet in the actual source package, you've still
declared source format 3.0 (quilt). You don't add a build-depends on
quilt when using dpkg-source in quilt "mode" unless you are doing some
unusual stuff with quilt - this package doesn't.

http://wiki.debian.org/Projects/DebSrc3.0#Doesa3.0.28quilt.29sourcepackageneedtobuild-dependonquilt.3F

That leaves you with all the .pc content in the diff.

http://man.he.net/man1/dpkg-source

Ask your sponsor or on debian-mentors if you're unsure but this diff is
a mess. Source Format 3.0 was meant to avoid the need to add an entire
patch system merely to fix release-critical bugs - you've missed the
point somewhere.

-- 


Neil Williams
=============
http://www.data-freedom.org/
http://www.linux.codehelp.co.uk/
http://e-mail.is-not-s.ms/

Attachment: pgpjsw7vXPx1M.pgp
Description: PGP signature


Reply to: