[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [request-tracker-maintainers] Stable update for request-tracker3.6



On Sun, Mar 28, 2010 at 09:57:02PM +0100, Adam D. Barratt wrote:
> Hi,
> 
> On Sun, 2010-03-28 at 14:26 +0100, Dominic Hargreaves wrote:
> > Please find attached a proposed stable update for request-tracker3.6.
> > 
> > Let me know if it's okay to upload.
> 
>  # ignore *.ucf-old and the like
> -find /etc/request-tracker3.6/RT_SiteConfig.d/ -type f \
> -    ! -name '*.ucf-*' -a \
> -    ! -name '*.dpkg-*' | sort | \
> +find "$SITE_CONFIG_INCLUDE_DIR" -type f \
> +    -regex "^$SITE_CONFIG_INCLUDE_DIR/[a-z0-9][a-z0-9-]+$" | sort | \
> 
> Apologies if I'm missing something wrt to the filename pattern, but is
> it intentional that this doesn't match a file called, e.g., "a"?

Yes, this is probably true. It's the same fragment in the
request-tracker3.8 package. Strictly speaking it should probably
have allowed single character files, so I'm not sure why the regex
is this way.

However, your question has prompted more thought and it's probably
not a suitable change for stable; certainly it changes the behaviour
a bit too much.

Please could you reconsider my request without that part of the patch?

Thanks,
Dominic.

-- 
Dominic Hargreaves | http://www.larted.org.uk/~dom/
PGP key 5178E2A5 from the.earth.li (keyserver,web,email)


Reply to: