Re: can we upload mod-wsgi 2.5-1~lenny1 to stable?

["Adam D. Barratt" <adam@adam-barratt.org.uk>]

On Sat, 2009-08-08 at 13:45 +0200, Piotr Ożarowski wrote:
> Debian Lenny was shipped with mod-wsgi v2.3. Upstream released two new
> bug fix versions since then - 2.4 and 2.5 (with bug fixes mostly
> backported from developement branch - 3.x). Since upstream changelog
> mentions[1] also new features (also backported from 3.x), we (Bernd and I)
> contacted upstream (who helped us a lot before) about these new features
> and he told us that these features are actually a bug fixes as well
> and he recommends not to strip them in an upload to Debian stable.

While I was having a look at the diff to try and identify which sections
correspond to particular upstream changes I spotted this, which looks a
little broken unless I'm missing something:

@@ -3538,7 +3583,7 @@
         }
     }
 
-    Py_INCREF(m);
+    Py_XDECREF(m);
 
     Py_INCREF(h);
 
This appears to be part of upstream r1244
(http://code.google.com/p/modwsgi/source/detail?r=1244&path=/trunk/mod_wsgi/mod_wsgi.c) for which the commit message is "Protect against decrementing reference count on NULL pointer".  The other two hunks of the commit do exactly that, exchanging Py_DECREF for Py_XDECREF, but replacing Py_INCREF with Py_XDECREF doesn't seem to make a lot of sense.

Regards,

Adam