[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: TPU for slim



Hi,
* Julien Cristau <jcristau@debian.org> [2009-07-22 13:11]:
> On Wed, Jul 22, 2009 at 12:43:51 +0200, Francesco P. Lovergine wrote:
> > On Wed, Jul 22, 2009 at 10:52:08AM +0200, Paul Wise wrote:
> > > On Wed, Jul 22, 2009 at 12:56 AM, Mike Massonnet<mmassonnet@gmail.com> wrote:
> > > 
> > > > Slim allows the user to take a screenshot by typing F11, which
> > > > currently defaults to /tmp/slim.png. A user might be able to put a
> > > > symlink there to point to any file on the fs and use it to corrupt
> > > > them. This tpu contains a fix that changes the default location to
> > > > /root/slim.png.
> > > 
> > > That directory may not exist if the admin has customised root's home
> > > directory. For example on my phone I use /home/root in the Debian
> > > install.
> > > 
> > 
> > A proper fix would be creating a unique file on-fly in a suitable /tmp subdir,
> > with a known pattern. That subdir should be created on fly and root owned.
> > 
> Or kill this misfeature.  Or kill slim entirely.

I'd vote for removing it completely with my security team 
hat on. Regarding just this bug it should work to fix this 
with:
screenshot_cmd      scrot $(mktemp -d /tmp/scrot_slim.XXXXXX)/scrot.jpg

as this is passed to system(), I didn't test this though.

Cheers
Nico
-- 
Nico Golde - http://www.ngolde.de - nion@jabber.ccc.de - GPG: 0xA0A0AAAA
For security reasons, all text in this mail is double-rot13 encrypted.

Attachment: pgpoXxncv0ZGL.pgp
Description: PGP signature


Reply to: