[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: update subversion-tools in stable



Peter Palfrader wrote:
> Hi,
> 
> Subversion-tools in lenny contains a commit email script, which
> unfortunately sends broken mails (all the headers are part of the body,
> and the headers empty).
> 
> Bugs #532903 and #508301 are about this issue, which has been fixed for
> sid+squeeze in late February.
> 
> weasel@intrepid:~/tmp$ cat ./subversion-1.5.6dfsg/debian/patches/commit-email2
> Fix commit-email.pl header formatting - properly omit the envelope
> 'From ' when not --stdout.  From upstream trunk r34134.  Bug #508301.
> 
> --- a/tools/hook-scripts/commit-email.pl.in
> +++ b/tools/hook-scripts/commit-email.pl.in
> @@ -557,7 +557,7 @@
>  
>      my @head;
>      my $formatted_date;
> -    if (defined $stdout)
> +    if ($stdout)
>        {
>          $formatted_date = strftime('%a %b %e %X %Y', localtime());
>          push(@head, "From $mail_from $formatted_date\n");
> 
> This is the same patch I wrote independently when I filed #532903.  The
> maintainer states that this fix "is trivial and obviously correct", and
> it does what I expect on the system where I applied it.
> 
> 
> Please consider allowing an update to subversion-tools for the next
> lenny point release.

Please upload.

Cheers

Luk


Reply to: