[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

proposed update of libaqbanking for lenny



Dear release masters,

libaqbanking 3.6.2-1 in Debian Lenny suffers a RC bug (#505509) causing
qt3-wizard, a little setup helper application, to segfault. The reason
is the use of an unassigned variable.

The attached patch libaqbanking_3.6.2-1+lenny1.interdiff.diff fixes this
issue. The proposed debian/changelog entry is:

libaqbanking (3.6.2-1+lenny1) stable; urgency=low

  * Apply upstream patch (SVN r1538) fixing forgotten variable
    assignment causing qt3-wizard to segfault (closes: #505509).

 -- Micha Lenk <micha@lenk.info>  Tue, 02 Jun 2009 14:24:13 +0200

Is it worth an upload to stable?

Regards
  Micha
diff -u libaqbanking-3.6.2/debian/changelog libaqbanking-3.6.2/debian/changelog
--- libaqbanking-3.6.2/debian/changelog
+++ libaqbanking-3.6.2/debian/changelog
@@ -1,3 +1,10 @@
+libaqbanking (3.6.2-1+lenny1) stable; urgency=low
+
+  * Apply upstream patch (SVN r1538) fixing forgotten variable
+    assignment causing qt3-wizard to segfault (closes: #505509).
+
+ -- Micha Lenk <micha@lenk.info>  Tue, 02 Jun 2009 14:24:13 +0200
+
 libaqbanking (3.6.2-1) unstable; urgency=low
 
   * New upstream release, fixing several crashes.
only in patch2:
unchanged:
--- libaqbanking-3.6.2.orig/src/plugins/backends/aqofxconnect/plugin/account.c
+++ libaqbanking-3.6.2/src/plugins/backends/aqofxconnect/plugin/account.c
@@ -31,6 +31,7 @@
 		       AB_PROVIDER_EXTEND_MODE em,
 		       GWEN_DB_NODE *db) {
   AO_ACCOUNT *ae;
+  assert(a);
 
   if (em==AB_ProviderExtendMode_Create ||
       em==AB_ProviderExtendMode_Extend) {
@@ -51,6 +52,8 @@
 
   }
   else if (em==AB_ProviderExtendMode_Save) {
+    ae = GWEN_INHERIT_GETDATA(AB_ACCOUNT, AO_ACCOUNT, a);
+    assert(ae);
     GWEN_DB_SetIntValue(db, GWEN_DB_FLAGS_OVERWRITE_VARS,
 			"maxPurposeLines", ae->maxPurposeLines);
     GWEN_DB_SetIntValue(db, GWEN_DB_FLAGS_OVERWRITE_VARS,

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: