Re: faad2 2.7 Transition
- Why are you hardcoding -DPIC and -fPIC into the CFLAGS in
debian/rules? This should really be unnecessary. It is also
unnecessary to set the optimization flags on purpose anymore.
- Why do you run the entire autoreconf sequence in the
override_dh_auto_configure rule? BTW, if you insist on doing so,
please replace the ./configure call in line 20 with dh_auto_configure.
- Why do you enable DRM support? In the past it has proven to make the
library unusable.
- libmp4ff-dev and faad2-dbg must depend on libmp4ff0.
- Please avoid the .{a,la,so} bashism in the -dev install files.
- Please use a *sane* watch file. The one you added is nearly unreadable.
- "* Move libfaad-dev to the front to be 'default' package debhelper
acts on." WTF is the purpose of changes like this?!
So far for the first check...
Fabian
--
Dipl.-Phys. Fabian Greffrath
Ruhr-Universität Bochum
Lehrstuhl für Energieanlagen und Energieprozesstechnik (LEAT)
Universitätsstr. 150, IB 3/134
D-44780 Bochum
Telefon: +49 (0)234 / 32-26334
Fax: +49 (0)234 / 32-14227
E-Mail: greffrath@leat.ruhr-uni-bochum.de
Reply to: