Proposed stable upload, fixing segfault on basic package functionality

[Gunnar Wolf <gwolf@gwolf.org>]

Hi,

I am preparing an upload for libnet-rawip-perl, as it segfaults on
quite basic functionality (one of the core API functions) in
Lenny. The patch that actually fixes this problem is:

diff --git a/RawIP.xs b/RawIP.xs
index 6c0ee52..cddc523 100644
--- a/RawIP.xs
+++ b/RawIP.xs
@@ -1454,7 +1454,6 @@ compile(p,fp,str,optimize,netmask)
 CODE:
     fp = (struct bpf_program *)safemalloc(sizeof(struct bpf_program));
     RETVAL = pcap_compile(p,fp,str,optimize,netmask);
-    Safefree(fp);
 OUTPUT: 
     fp
     RETVAL

I am attaching the full package diff between 0.23-2 (current version
in Lenny) and this version; this patch was acknowledged and integrated
upstream in 0.24. I am also performing the upload to 'stable'.

Thanks,

-- 
Gunnar Wolf - gwolf@gwolf.org - (+52-55)5623-0154 / 1451-2244
PGP key 1024D/8BB527AF 2001-10-23
Fingerprint: 0C79 D2D1 2C4E 9CE4 5973  F800 D80E F35A 8BB5 27AF

Index: debian/control
===================================================================
--- debian/control	(.../trunk/libnet-rawip-perl)	(revision 15675)
+++ debian/control	(.../branches/lenny/libnet-rawip-perl)	(working copy)
@@ -2,7 +2,7 @@
 Section: perl
 Priority: extra
 Maintainer: Debian Perl Group <pkg-perl-maintainers@lists.alioth.debian.org>
-Uploaders: Christian Hammers <ch@debian.org>
+Uploaders: Christian Hammers <ch@debian.org>, Gunnar Wolf <gwolf@debian.org>
 Standards-Version: 3.7.3
 Build-Depends: cdbs, debhelper (>= 6), liblist-moreutils-perl, perl (>= 5.8), 
  libpcap-dev, libtest-pod-perl, libtest-pod-coverage-perl,
Index: debian/changelog
===================================================================
--- debian/changelog	(.../trunk/libnet-rawip-perl)	(revision 15675)
+++ debian/changelog	(.../branches/lenny/libnet-rawip-perl)	(working copy)
@@ -1,3 +1,11 @@
+libnet-rawip-perl (0.23-2+lenny1) stable; urgency=low
+
+  * Added myself as an uploader
+  * Included patch by Franck Joncourt fixing segfault upon pcapinit
+    function use (Closes: #523351)
+
+ -- Gunnar Wolf <gwolf@debian.org>  Sat, 11 Apr 2009 12:04:39 -0500
+
 libnet-rawip-perl (0.23-2) unstable; urgency=low
 
   * Add libtest-pod-perl, libtest-pod-coverage-perl,
Index: debian/patches/fix_pcapinit_segfault
===================================================================
--- debian/patches/fix_pcapinit_segfault	(.../trunk/libnet-rawip-perl)	(revision 0)
+++ debian/patches/fix_pcapinit_segfault	(.../branches/lenny/libnet-rawip-perl)	(revision 33052)
@@ -0,0 +1,12 @@
+Index: libnet-rawip-perl/RawIP.xs
+===================================================================
+--- libnet-rawip-perl.orig/RawIP.xs	2009-04-11 12:36:10.000000000 -0500
++++ libnet-rawip-perl/RawIP.xs	2009-04-11 12:36:22.000000000 -0500
+@@ -1454,7 +1454,6 @@
+ CODE:
+     fp = (struct bpf_program *)safemalloc(sizeof(struct bpf_program));
+     RETVAL = pcap_compile(p,fp,str,optimize,netmask);
+-    Safefree(fp);
+ OUTPUT: 
+     fp
+     RETVAL
Index: debian/patches/series
===================================================================
--- debian/patches/series	(.../trunk/libnet-rawip-perl)	(revision 15675)
+++ debian/patches/series	(.../branches/lenny/libnet-rawip-perl)	(working copy)
@@ -1 +1,2 @@
+fix_pcapinit_segfault
 tests_no_network.patch

Attachment: pgpd4DEspM1Z0.pgp
Description: PGP signature