[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: irqbalance update in stable?



This one time, at band camp, Philipp Kern said:
> On Wed, Mar 18, 2009 at 10:34:05PM +0000, Stephen Gran wrote:
> > This one time, at band camp, Peter Palfrader said:
> > > #517183 segv on startup makes irqbalance completely broken on our
> > > sparcs.
> > > 
> > > There has been a patch in the BTS for a bit over 10 days now, yet it
> > > is still unresolved in sid (0.55-3 does not fix it despite the changelog
> > > entry) and also in lenny.
> > > 
> > > I would like to see this issue get resolved in lenny, tho we are getting
> > > pretty late for lenny r1.
> > > What's the plan here?
> > For reference, the patch is attached.
> 
> Apart from the unappealing changelog entry: what does it solve, exactly?
> Just ignore the opendir failure without any warning?

Sorry about the changelog entry - that was just me creating an interrim
package on the machine with issues to see if it would work.  The
information is in the bug report, but I'll recap.

The current situation is that irqbalance misparses /proc/interrupts on
at least sparc.  This misparse leads irqbalance to try to open
/proc/irq/0 (which does not exist) and then segv since it ignores the
opendir failure.  The patch in the BTS only makes it notice the opendir
failure and continue on without that entry.  I see no point in warning
about the opendir failure, since irqbalance can't, by definition, do
anything about IRQs the kernel hasn't set up /proc entries for.

I'm happy to fix up the changelog entry to make it more suitable for a
real upload (I'm also happy for the maintainer to do the upload instead
of me, but he implied that he would be unable to).

Cheers,
-- 
 -----------------------------------------------------------------
|   ,''`.                                            Stephen Gran |
|  : :' :                                        sgran@debian.org |
|  `. `'                        Debian user, admin, and developer |
|    `-                                     http://www.debian.org |
 -----------------------------------------------------------------

Attachment: signature.asc
Description: Digital signature


Reply to: