[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: roundup bug (#510342)



Hi,

On Thu, 05.02.2009 at 12:36:50 +0100, Toni Mueller <toni@debian.org> wrote:
> #514221 - PostgreSQL backend does not support tracker names with dashes

this is a two-line patch quoting the tracker's name in SQL:

diff -urNad roundup-1.4.4~/roundup/backends/back_postgresql.py roundup-1.4.4/roundup/backends/back_postgresql.py
--- roundup-1.4.4~/roundup/backends/back_postgresql.py  2009-02-05 17:19:42.000000000 +0100
+++ roundup-1.4.4/roundup/backends/back_postgresql.py   2009-02-05 17:20:11.000000000 +0100
@@ -35,13 +35,13 @@
 
 def db_create(config):
     """Clear all database contents and drop database itself"""
-    command = "CREATE DATABASE %s WITH ENCODING='UNICODE'"%config.RDBMS_NAME
+    command = "CREATE DATABASE \"%s\" WITH ENCODING='UNICODE'"%config.RDBMS_NAME
     logging.getLogger('hyperdb').info(command)
     db_command(config, command)
 
 def db_nuke(config, fail_ok=0):
     """Clear all database contents and drop database itself"""
-    command = 'DROP DATABASE %s'% config.RDBMS_NAME
+    command = 'DROP DATABASE "%s"'% config.RDBMS_NAME
     logging.getLogger('hyperdb').info(command)
     db_command(config, command)

> #514215 - roundup: broken "Roundup docs" link

This is also a two-line patch, but for page templates:

diff -urNad roundup-1.4.4~/templates/classic/html/page.html roundup-1.4.4/templates/classic/html/page.html
--- roundup-1.4.4~/templates/classic/html/page.html     2008-03-01 09:06:42.000000000 +0100
+++ roundup-1.4.4/templates/classic/html/page.html      2009-02-05 17:15:34.000000000 +0100
@@ -164,7 +164,7 @@
   </p>
   <p class="userblock">
    <b i18n:translate="">Help</b><br>
-   <a href="http://roundup.sourceforge.net/doc-1.0/";
+   <a href="http://www.roundup-tracker.org/docs.html";
     i18n:translate="">Roundup docs</a>
   </p>
  </td>
diff -urNad roundup-1.4.4~/templates/minimal/html/page.html roundup-1.4.4/templates/minimal/html/page.html
--- roundup-1.4.4~/templates/minimal/html/page.html     2008-03-01 09:08:05.000000000 +0100
+++ roundup-1.4.4/templates/minimal/html/page.html      2009-02-05 17:15:28.000000000 +0100
@@ -151,7 +151,7 @@
   </p>
   <p class="userblock">
    <b i18n:translate="">Help</b><br>
-   <a href="http://roundup.sourceforge.net/doc-1.0/";
+   <a href="http://www.roundup-tracker.org/docs.html";
     i18n:translate="">Roundup docs</a>
   </p>
  </td>


I also adjusted the copyright file to take note of the new home page.


I've opted to upload the package to my DD home page to avoid
cluttering the "semi-approved" version 1.4.4-3 in unstable:

http://people.debian.org/~toni/roundup/


Please advise about any desired action.


TIA!


-- 
Kind regards,
--Toni++

Attachment: signature.asc
Description: Digital signature


Reply to: