[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [SRM] devscripts update (#507482)

On Fri, 2009-01-09 at 16:33 -0800, Russ Allbery wrote:
> "Adam D. Barratt" <adam@adam-barratt.org.uk> writes:
> > On Fri, 2009-01-09 at 10:18 +0100, Philipp Kern wrote:
> >> but I wonder if the usage of $TEMP_DIR after cd and rm should be quoted?
> > Quoting shouldn't be required around the variable, as the output of
> > mktemp should be sane; I'm happy to add quoting if you'd prefer,
> > however. (To be honest, I don't think any of the quoting around the
> > mktemp call itself is actually required, I just tend to apply
> > belt-and-braces).
> It looks like you're using mktemp -t, which is documented as using the
> setting of TMPDIR.  Are you sure the quoting isn't needed even if someone
> has TMPDIR set to something like "/home/user/Temporary Files"?

Hmmm, yes, that's a reasonable point; thanks.


Reply to: