Re: please allow mailman/1:2.1.11-5

[Thijs Kinkhorst <thijs@debian.org>]

Hi Adeodato,

On Tuesday 11 November 2008 18:42, Adeodato Simó wrote:
> * Thijs Kinkhorst [Tue, 11 Nov 2008 16:53:14 +0100]:
> > Hi,
>
> Hello,
>
> > Please allow mailman/1:2.1.11-5 to fix a release critical bug. Adeodato
> > already unblocked -4 for this bug, but another upload was necessary to
> > handle a special case in the init script. Changelog below.
> >
> > mailman  (1:2.1.11-5) unstable; urgency=high
> >
> >    * Make init script also cope with non-specified site list.
> >
> >  -- Thijs Kinkhorst <thijs@debian.org>  Sun, 09 Nov 2008 11:26:46 +0100
>
> I reviewed -5 the other day already, and had some concerns. Good thing
> you wrote. Though I now see some of them are not a regression.


> Anyway, only the `set -e` bit is important, please upload to fix at
> least that one.

I am not sure if that actually was a problem, because I tested it and it 
worked, at least in my environment. Still, I think your suggestions do 
improve the detection code so I've included them. Besides that I now also 
mention the detected site list name in the warning we output when the list is 
not found.

Can you please review and approve mailman/1:2.1.11-6?

thanks,
Thijs