[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Please unblock security fix



Andrew Lee <andrew@linux.org.tw> writes:
> Please unblock gpicview package which fixing following security issues:
> #495968 CVE-2008-3791 insecure temporary file usage
> #498022 CVE-2008-3904 arbitrary code execution via crafted file name
[gpicview]

Unblocked, but:

+Standards-Version: 3.8.0.0

The last .0 is useless.

+INSTALL = install
+INSTALL_FILE    = $(INSTALL) -p    -o root -g root  -m  644
+INSTALL_PROGRAM = $(INSTALL) -p    -o root -g root  -m  755
+INSTALL_SCRIPT  = $(INSTALL) -p    -o root -g root  -m  755
+INSTALL_DIR     = $(INSTALL) -p -d -o root -g root  -m  755

Why, oh, why?

+ifeq (,$(filter nostrip,$(DEB_BUILD_OPTIONS)))
+    INSTALL_PROGRAM += -s
+endif

Not needed, you are using dh_strip, which is handling DEB_BUILD_OPTIONS
just fine.

|    CFLAGS="$(CFLAGS)" LDFLAGS="-Wl,-z,defs" ./configure \
|    --host=$(DEB_HOST_GNU_TYPE) \
|    --build=$(DEB_BUILD_GNU_TYPE) \
|    --prefix=/usr \
|    --mandir=\$${prefix}/share/man \
|    --infodir=\$${prefix}/share/info \
|    CFLAGS="$(CFLAGS)" LDFLAGS="-Wl,-z,defs"

Count the number of CFLAGS.

Marc
-- 
BOFH #97:
Small animal kamikaze attack on power supplies

Attachment: pgpb523PDL0Pp.pgp
Description: PGP signature


Reply to: