[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#504340: djvulibre-plugin/testing and #504340



On Thursday 18 December 2008 18:16:54 Thomas Viehmann wrote:
> Thomas Viehmann
>
>   if (map_lookup(&instance, id, &inst) < 0)
>     return NPERR_INVALID_INSTANCE_ERROR;
>-  cur_window = inst->window;
>+  cur_window = (inst) ? inst->window : 0;

The problem here is that inst should not be zero if map_lookup returns correctly.
Like the previous patch, a seemingly unrelated change seems to solve the problem.
The bug appears or disappears depending on the compiler options
or depending on the insertion of printf in the right places.
Your patch cannot hurt, but I do not think it is the end of the story either...

- L.


Reply to: