[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

ROM: Upload of swfdec-mozilla 0.6.0-5 to testing-proposed-updates



Hi!

After talking with upstream about #496741 and #503315 (one of them is a RC
bug) it has said that this seems to be upstream's bug
http://bugs.freedesktop.org/show_bug.cgi?id=15962
which was solved with this patch:
http://cgit.freedesktop.org/swfdec/swfdec-mozilla/diff/src/swfmoz_player.c?h=0.8&id=c37f02fc20a4ffc74eecfceeaff913a250933320
on newer versions, applying it to 0.6.0 would be like this:

--- swfdec-mozilla-0.6.0.orig/src/swfmoz_player.c
+++ swfdec-mozilla-0.6.0/src/swfmoz_player.c
@@ -353,10 +353,6 @@
     gdk_region_destroy (player->repaint);
     player->repaint = NULL;
   }
-  if (player->initial) {
-    g_object_unref (player->initial);
-    player->initial = NULL;
-  }
   if (player->loaders) {
     g_object_unref (player->loaders);
     player->loaders = NULL;

Quoting upstream:

[21:07] <Company> manty: i can tell you the code is wrong in 0.6, because it
        unrefs an NPStream
[21:07] <Company> manty: so whenever player->initial is set, swfdec-mozilla is
        gonna crash

Reporters have not been clear on their bugs, they are unresponsive to my
requests of more info and I cannot replicate the problem on amd64 or i386 so
I cannot tell if the patch will really fix this bugs or not, but upstream
thinks it will and at least will fix the crash upstream comments.

So... if you think this is ok I'll try to upload through
testing-proposed-updates (we have 0.8.2 in unstable) or whatever you tell me
to do.

Regards...
-- 
Manty/BestiaTester -> http://manty.net


Reply to: