Re: Bug#502823: iodine: piuparts test fails: /var/lib/dpkg/info/iodine.postinst: line 27: ./MAKEDEV: No such file or directory
- To: gregor herrmann <gregoa@debian.org>, Lucas Nussbaum <lucas@lucas-nussbaum.net>, Alexander Wirt <formorer@debian.org>
- Cc: 502823@bugs.debian.org, debian-release@lists.debian.org, Tony Mancill <tmancill@debian.org>
- Subject: Re: Bug#502823: iodine: piuparts test fails: /var/lib/dpkg/info/iodine.postinst: line 27: ./MAKEDEV: No such file or directory
- From: Adeodato Simó <dato@net.com.org.es>
- Date: Wed, 22 Oct 2008 11:58:37 +0200
- Message-id: <20081022095837.GS29100@chistera.yi.org>
- Mail-followup-to: gregor herrmann <gregoa@debian.org>, Lucas Nussbaum <lucas@lucas-nussbaum.net>, Alexander Wirt <formorer@debian.org>, 502823@bugs.debian.org, debian-release@lists.debian.org, Tony Mancill <tmancill@debian.org>
- In-reply-to: <20081020172830.GA27575@apu.snow-crash.org> <20081020174353.GB19829@xanadu.blop.info> <20081020172054.GA11445@belanna.comodo.priv.at>
- References: <20081020052807.GA24073@xanadu.blop.info> <20081020172054.GA11445@belanna.comodo.priv.at> <20081020172830.GA27575@apu.snow-crash.org> <20081020052807.GA24073@xanadu.blop.info> <20081020172054.GA11445@belanna.comodo.priv.at> <20081020174353.GB19829@xanadu.blop.info> <20081020052807.GA24073@xanadu.blop.info> <20081020172054.GA11445@belanna.comodo.priv.at>
* gregor herrmann [Mon, 20 Oct 2008 19:20:54 +0200]:
> Index: debian/postinst
> ===================================================================
> --- debian/postinst (revision 1469)
> +++ debian/postinst (working copy)
> @@ -23,8 +23,11 @@
> case "$1" in
> configure)
> # we need a tun device
> - echo "Creating device /dev/net/tun ..."
> - cd /dev && ./MAKEDEV tun
> + if [ ! -c /dev/net/tun ] && [ -x /dev/MAKEDEV ] ; then
> + echo "Creating device /dev/net/tun ..."
> + cd /dev
> + ./MAKEDEV tun || true
> + fi
> # and we want a special user
> adduser --quiet --system --home /var/run/iodine iodine
> # generate /etc/default/iodine
This patch looks fine. As far as I know, you could (should?) Depend:
udev | makedev as well.
* Lucas Nussbaum [Mon, 20 Oct 2008 19:43:53 +0200]:
> Couldn't you depend on makedev?
See above.
* Alexander Wirt [Mon, 20 Oct 2008 19:28:31 +0200]:
> if [ -d "/dev/.static" ]; then
> cd /dev/.static
> ./MAKEDEV ....
> else
> cd /dev/
> ./MAKEDEV
> fi
No, that is wrong. Check with Md if you want to know the reasons.
Cheers,
--
Adeodato Simó dato at net.com.org.es
Debian Developer adeodato at debian.org
Listening to: Compay Segundo - La Pluma
Reply to: