Re: irqbalance update in etch?

[Peter Palfrader <weasel@debian.org>]

Martin Zobel-Helas schrieb am Mittwoch, dem 01. Oktober 2008:

> Please mention the Bug# in the changelog. if there isn't any, please go
> ahead and open an RC bug.

Done.  Uploaded this to delayed 5, so if there's anything else we should
have time to fix up stuff.

diff -u irqbalance-0.12/debian/changelog irqbalance-0.12/debian/changelog
--- irqbalance-0.12/debian/changelog
+++ irqbalance-0.12/debian/changelog
@@ -1,3 +1,15 @@
+irqbalance (0.12-7etch1) stable; urgency=low
+
+  * Non maintainer upload.
+  * irqbalance would segfault on startup when /proc/interrupts contains
+    an interrupt with a number of 256 or larger, since internally it
+    stored data in a fixed-length array.  Newer versions (say 0.55) have
+    replaced the data structure with a list so this is fixed there.  For
+    now we just skip interrupts with such high numbers, since it's the
+    least invasive approach during the stable cycle (closes: #500985).
+
+ -- Peter Palfrader <weasel@debian.org>  Fri, 03 Oct 2008 10:09:14 +0200
+
 irqbalance (0.12-7) unstable; urgency=low
 
   * debian/po/es.po: Add Spanish translation from César Gómez
only in patch2:
unchanged:
--- irqbalance-0.12.orig/procinterrupts.c
+++ irqbalance-0.12/procinterrupts.c
@@ -103,6 +103,14 @@
 				ret = sscanf(word,"%i",&irqnumber);
 				if (!ret)  /* non numeric end stuff */
 					irqnumber = MAX_INTERRUPTS-1; 
+				/* This version of irqbalance cannot handle interrups larger
+				 * than 255, so skip stuff right here.  Newer versions
+				 * have replaced the length limited array with a list,
+				 * so this limitation is no longer present in say 0.55.
+				 * Also see http://bugs.debian.org/500985
+				 */
+				if (irqnumber < 0 || irqnumber >= MAX_INTERRUPTS)
+					break;
 			/* then N columns of counts, where N is the number of cpu's */
 			} else if (column <= cpucount) {
 				sscanf(word,"%lli",&count);


weasel@intrepid:~/projects/debian/nmu/irqbalance$ debdiff /var/cache/apt/archives/irqbalance_0.12-7_i386.deb irqbalance_0.12-7etch1_i386.deb
File lists identical (after any substitutions)

Control files: lines which differ (wdiff format)
------------------------------------------------
Installed-Size: [-120-] {+72+}
Version: [-0.12-7-] {+0.12-7etch1+}


-- 
                           |  .''`.  ** Debian GNU/Linux **
      Peter Palfrader      | : :' :      The  universal
 http://www.palfrader.org/ | `. `'      Operating System
                           |   `-    http://www.debian.org/