Re: pre-approval for perl 5.10.0-15 changes
On Sun, Sep 28, 2008 at 05:00:47PM +0200, Luk Claes wrote:
> Niko Tyni wrote:
> > Please ack/nack the attached patches. Barring any surprises, I'd like
> > to upload perl 5.10.0-15 in a few days when -14 has entered testing.
>
> Please upload.
Thanks, done. Unfortunately a new encoding issue with the "pod2man --utf8"
functionality has cropped up; see #500210.
I'd like to upload this:
perl (5.10.0-16) unstable; urgency=low
* revert the perldoc "pod2man --utf8" change from 5.10.0-14. The
--utf8 option may output incorrect UTF-8 for POD documents that
don't specify an explicit =encoding. (Reopens: #492037)
* Discuss the above issue in the Pod::Man and pod2man documentation.
-- Niko Tyni <ntyni@debian.org> Thu, 02 Oct 2008 13:26:06 +0300
Patch against -15 attached with the duplication in debian/patches
filtered out. Is this OK with you?
I don't see any point in waiting for -15 to get into lenny first (it's
only two days old or so), but please let me know if you prefer that.
I don't expect further trouble after this; the --utf8 option becomes
totally opt-in but is usable given the documented limitation.
--
Niko Tyni ntyni@debian.org
diff -u perl-5.10.0/patches-applied perl-5.10.0/patches-applied
diff -u perl-5.10.0/pod/pod2man.PL perl-5.10.0/pod/pod2man.PL
--- perl-5.10.0/pod/pod2man.PL
+++ perl-5.10.0/pod/pod2man.PL
@@ -259,6 +259,13 @@
supported by many implementations and may even result in segfaults and
other bad behavior.
+Be aware that using this option currently only works properly on UTF-8
+encoded POD files that use the C<=encoding> POD command. If the option
+is enabled on an input POD file that doesn't declare an =encoding of
+UTF-8, any use of SE<lt>E<gt> in that POD file will result in invalid UTF-8,
+even if there's no use of high-bit characters in the input POD at all.
+This is a bug that will be fixed in later versions.
+
=item B<-v>, B<--verbose>
Print out the name of each output file as it is being generated.
@@ -294,6 +301,9 @@
Lots of this documentation is duplicated from L<Pod::Man>.
+As mentioned earlier in this document, the C<--utf8> option is currently
+broken on non-UTF-8 input.
+
=head1 NOTES
For those not sure of the proper layout of a man page, here are some notes
diff -u perl-5.10.0/lib/Pod/Man.pm perl-5.10.0/lib/Pod/Man.pm
--- perl-5.10.0/lib/Pod/Man.pm
+++ perl-5.10.0/lib/Pod/Man.pm
@@ -1592,6 +1592,13 @@
by many implementations and may even result in segfaults and other bad
behavior.
+Be aware that using this option currently only works properly on UTF-8
+encoded POD files that use the C<=encoding> POD command. If the option
+is enabled on an input POD file that doesn't declare an =encoding of
+UTF-8, any use of SE<lt>E<gt> in that POD file will result in invalid UTF-8,
+even if there's no use of high-bit characters in the input POD at all.
+This is a bug that will be fixed in later versions.
+
=back
The standard Pod::Simple method parse_file() takes one argument naming the
@@ -1627,6 +1634,9 @@
=head1 BUGS
+As mentioned earlier in this document, the C<utf8> option is currently
+broken on non-UTF-8 input.
+
There is currently no way to turn off the guesswork that tries to format
unmarked text appropriately, and sometimes it isn't wanted (particularly
when using POD to document something other than Perl). Most of the work
reverted:
--- perl-5.10.0/lib/Pod/Perldoc/ToMan.pm
+++ perl-5.10.0.orig/lib/Pod/Perldoc/ToMan.pm
@@ -60,10 +60,6 @@
unless -e $pod2man;
}
- eval { require Pod::Man };
- $switches .= " --utf8"
- if (!$@ && $Pod::Man::VERSION >= 2.18);
-
my $command = "$pod2man $switches --lax $file | $render -man";
# no temp file, just a pipe!
diff -u perl-5.10.0/debian/changelog perl-5.10.0/debian/changelog
--- perl-5.10.0/debian/changelog
+++ perl-5.10.0/debian/changelog
@@ -1,3 +1,12 @@
+perl (5.10.0-16) unstable; urgency=low
+
+ * revert the perldoc "pod2man --utf8" change from 5.10.0-14. The
+ --utf8 option may output incorrect UTF-8 for POD documents that
+ don't specify an explicit =encoding. (Reopens: #492037)
+ * Discuss the above issue in the Pod::Man and pod2man documentation.
+
+ -- Niko Tyni <ntyni@debian.org> Thu, 02 Oct 2008 13:26:06 +0300
+
perl (5.10.0-15) unstable; urgency=low
* Fix Sys::Syslog slowness when logging with non-native mechanisms.
diff -u perl-5.10.0/debian/patches/26_fix_pod2man_upgrade perl-5.10.0/debian/patches/26_fix_pod2man_upgrade
reverted:
Reply to: