Re: Please unblock security fix

[Andrew Lee <andrew@linux.org.tw>]

Marc 'HE' Brockschmidt wrote:
> +Standards-Version: 3.8.0.0
> 
> The last .0 is useless.
> 
> +INSTALL = install
> +INSTALL_FILE    = $(INSTALL) -p    -o root -g root  -m  644
> +INSTALL_PROGRAM = $(INSTALL) -p    -o root -g root  -m  755
> +INSTALL_SCRIPT  = $(INSTALL) -p    -o root -g root  -m  755
> +INSTALL_DIR     = $(INSTALL) -p -d -o root -g root  -m  755
> 
> Why, oh, why?
> 
> +ifeq (,$(filter nostrip,$(DEB_BUILD_OPTIONS)))
> +    INSTALL_PROGRAM += -s
> +endif
> 
> Not needed, you are using dh_strip, which is handling DEB_BUILD_OPTIONS
> just fine.
> 
> |    CFLAGS="$(CFLAGS)" LDFLAGS="-Wl,-z,defs" ./configure \
> |    --host=$(DEB_HOST_GNU_TYPE) \
> |    --build=$(DEB_BUILD_GNU_TYPE) \
> |    --prefix=/usr \
> |    --mandir=\$${prefix}/share/man \
> |    --infodir=\$${prefix}/share/info \
> |    CFLAGS="$(CFLAGS)" LDFLAGS="-Wl,-z,defs"
> 
> Count the number of CFLAGS.

Got it. I fixed these in my local repos already. I planed to upload
together with svn head(fix #497005) into sid after this went into lenny.

Thanks,

-Andrew