[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Pre-approval for the hopefully final lenny perl version



Hi release team,

I'd like to upload the (hopefully) final version of perl for lenny
with these changes. Could you please ack or nack them?

  * Make perl-base Pre-Depend on dpkg (>= 1.14.20), whose Essential scripts
    don't break when liblocale-gettext-perl and perl-base aren't binary
    compatible. (Closes: #488300)

I really hope this fixes any remaining Locale::gettext problems.

  * Fix tainted usage of $ENV{TMPDIR} as an sprintf format in CGI.pm.
   (Closes: #494679)

This was already acked by Marc earlier and blocks an RC bug in
libapache2-mod-perl2.

  * Disable ext/threads/shared/t/stress.t on m68k for now. (Closes: #495826)

Is it too late for non-release-arch porter fixes?

  * Improve Etch->Lenny upgrades by making perl-base conflict with the eight
    XS module packages in Etch that lacked the required perlapi-* dependency.
    (Closes: #494779)

This is needed for partial upgrades. It is kind of invasive, but leaving
those packages in the cold seems wrong to me. Other solutions welcome.
I've double-checked the conflict versions, but more eyeballs wouldn't
hurt.

  * Update to podlators-2.1.2 to get the 'pod2man --utf8' functionality
    in Lenny. (Closes: #480997)

This has had quite a long thread ("pod2man update") here on -release
with no final answer yet.  The patch isn't that bad after all, but I
certainly understand if you want to reject it this late.

Patches attached, named by the bug numbers, except the pod2man
one, which can be found in my recent debian-release mail,
<20080829060253.GA5212@rebekka> or

 http://lists.debian.org/debian-release/2008/08/msg01478.html

Once again, thanks for your work on the release.
-- 
Niko Tyni   ntyni@debian.org
diff --git a/debian/control b/debian/control
index 47bb5e7..a55d684 100644
--- a/debian/control
+++ b/debian/control
@@ -13,7 +13,7 @@ Package: perl-base
 Essential: yes
 Priority: required
 Architecture: any
-Pre-Depends: ${shlibs:Depends}
+Pre-Depends: ${shlibs:Depends}, dpkg (>= 1.14.20)
 Conflicts: autoconf2.13 (<< 2.13-45), libscalar-list-utils-perl (<< 1:1.18-1), libxsloader-perl (<< 0.08-1)
 Replaces: perl (<= 5.10.0-9), perl-modules (<< 5.10.0-12), libperl5.8 (<< 5.8.0-20), libscalar-list-utils-perl, libclass-multimethods-perl (<< 1.70-4), libxsloader-perl 
 Provides: perl5-base, ${perlapi:Provides}, libscalar-list-utils-perl, libxsloader-perl
Fix tainted usage of $ENV{TMPDIR} as an sprintf format in CGI.pm.

(Closes: #494679)

[rt.perl.org #50322]
Bleadperl change 33143.

Note that the inconsistent usage of backslashes doesn't matter, as
the whole thing is eval'd in.
diff --git a/lib/CGI.pm b/lib/CGI.pm
index c0158cb..1bc74a3 100644
--- a/lib/CGI.pm
+++ b/lib/CGI.pm
@@ -4032,7 +4032,7 @@ sub new {
     my $filename;
     find_tempdir() unless -w $TMPDIRECTORY;
     for (my $i = 0; $i < $MAXTRIES; $i++) {
-	last if ! -f ($filename = sprintf("${TMPDIRECTORY}${SL}CGItemp%d",$sequence++));
+	last if ! -f ($filename = sprintf("\%s${SL}CGItemp%d",$TMPDIRECTORY,$sequence++));
     }
     # check that it is a more-or-less valid filename
     return unless $filename =~ m!^([a-zA-Z0-9_ \'\":/.\$\\-]+)$!;
Disable ext/threads/shared/t/stress.t on m68k for now. (Closes: #495826)

diff --git a/ext/threads/shared/t/stress.t b/ext/threads/shared/t/stress.t
index 86a04e2..93e2311 100644
--- a/ext/threads/shared/t/stress.t
+++ b/ext/threads/shared/t/stress.t
@@ -15,6 +15,10 @@ BEGIN {
         print("1..0 # Skip: Broken under HP-UX 10.20\n");
         exit(0);
     }
+    if ($^O eq 'linux' && $Config{archname} =~ /^m68k/) {
+        print("1..0 # Skip: no TLS on m68k yet <http://bugs.debian.org/495826>\n");
+        exit(0);
+    }
 }
 
 use ExtUtils::testlib;
diff --git a/debian/control b/debian/control
index a55d684..799785d 100644
--- a/debian/control
+++ b/debian/control
@@ -14,7 +14,15 @@ Essential: yes
 Priority: required
 Architecture: any
 Pre-Depends: ${shlibs:Depends}, dpkg (>= 1.14.20)
-Conflicts: autoconf2.13 (<< 2.13-45), libscalar-list-utils-perl (<< 1:1.18-1), libxsloader-perl (<< 0.08-1)
+Conflicts: autoconf2.13 (<< 2.13-45), libscalar-list-utils-perl (<< 1:1.18-1), libxsloader-perl (<< 0.08-1),
+ libcflow-perl (<< 1:0.68-11.1),
+ libqt-perl (<< 3.008-3),
+ libclass-methodmaker-perl (<< 2.10-1),
+ libclearsilver-perl (<< 0.10.4-1.1),
+ libhamlib2-perl (<< 1.2.6.2-6),
+ libsys-cpu-perl (<< 0.40-2.1),
+ megahal (<< 9.1.1a-5),
+ razor (<< 1:2.84-6)
 Replaces: perl (<= 5.10.0-9), perl-modules (<< 5.10.0-12), libperl5.8 (<< 5.8.0-20), libscalar-list-utils-perl, libclass-multimethods-perl (<< 1.70-4), libxsloader-perl 
 Provides: perl5-base, ${perlapi:Provides}, libscalar-list-utils-perl, libxsloader-perl
 Suggests: perl

Attachment: signature.asc
Description: Digital signature


Reply to: