[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Please unblock avahi 0.6.23-2

Michael Biebl <biebl@debian.org> writes:
> Marc 'HE' Brockschmidt wrote:
>> Could you please provide a cleaned up diff (without this and the autofoo
>> crap) for review?
> No problem.
> I created a diff (avahi.diff.gz) between 0.6.22 and 0.6.23 using the git
> repository. As most of the changes are po/ related, I removed this
> directory from the diff. The actual code changes are minimal and bug fix
> only.

Well, that looks mostly OK. In fact, I love this part:
-            /* This is the second time we got no response, so let's
+            /* This is the 4th time we got no response, so let's

> The diff for the debian related changes is in debian.diff.gz

+    # update init script symlinks for new runlevels and priorities for upgrades
+    # from older versions
+    if dpkg --compare-versions "$2" lt-nl 0.6.22-4; then
+      echo "Reinstalling init script for new runlevels and priorities ..." >&2
+      # remove old init script symlinks; dh_installinit adds the proper
+      # update-rc.d snippet later on
+      update-rc.d -f avahi-daemon remove >/dev/null
+    fi

Dude. That's going to remove all my carefully renamed
/etc/rc[2345].d/K??avahi-daemon links, just to replace them with new
start links. Not nice.

BOFH #417:
Computer room being moved.  Our systems are down for the weekend.

Attachment: pgpLz64NKZ73G.pgp
Description: PGP signature

Reply to: