[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: please unblock libx500-dn-perl/0.29-1



On Wed, Aug 13, 2008 at 17:54:50 +1000, Aníbal Monsalve Salazar wrote:

> The last version of libx500-dn-perl in testing was 0.28-1 which had a
> grave bug unfixed for more than 14 months.
> 
> The debdiff between the version that was in testing and the current one
> in unstable is trivial.
> 
Bumping debhelper compat from 4 to 7 is anything but "trivial".

> The version in unstable works correctly with libparse-recdescent-perl.
> 
> Please unblock libx500-dn-perl/0.29-1
> 
> The debdiff is below.
> 
> debdiff libx500-dn-perl_0.28-1.dsc libx500-dn-perl_0.29-1.dsc
> diff -Nru libx500-dn-perl-0.28/Changes libx500-dn-perl-0.29/Changes
> --- libx500-dn-perl-0.28/Changes	2002-05-08 01:25:09.000000000 +1000
> +++ libx500-dn-perl-0.29/Changes	2007-07-09 02:41:21.000000000 +1000
> @@ -1,5 +1,7 @@
>  Revision history for Perl extension X500::DN.
>  
> +0.29  added missing PREREQ_PM in Makefile.PL
> +
>  0.28  force users to use ParseRFC2253 instead of ParseOpenSSL, now that we changed openssl to support '-nameopt RFC2253' everywhere.
>        tests adjusted accordingly.
>  
> diff -Nru libx500-dn-perl-0.28/debian/changelog libx500-dn-perl-0.29/debian/changelog
> --- libx500-dn-perl-0.28/debian/changelog	2008-08-13 17:27:23.000000000 +1000
> +++ libx500-dn-perl-0.29/debian/changelog	2008-08-13 17:27:23.000000000 +1000
> @@ -1,6 +1,23 @@
> +libx500-dn-perl (0.29-1) unstable; urgency=low
> +
> +  * QA upload.
> +  * New upstream release
> +  * Maintainer is Debian QA Group <packages@qa.debian.org>
> +  * Add homepage control line
> +  * Add debian/watch
> +  * Fix dependency problem with libparse-recdescent-perl; closes: #482125
> +  * Fix the following lintian issues:
> +    W: debian-rules-sets-DH_COMPAT line 9
> +    W: debian-rules-ignores-make-clean-error line 35
> +    W: binary-arch-rules-but-pkg-is-arch-indep
> +    W: ancient-standards-version 3.6.0 (current is 3.8.0)
> +    E: clean-should-be-satisfied-by-build-depends debhelper
> +    W: debian-copyright-line-too-long line 4
> +
> + -- Anibal Monsalve Salazar <anibal@debian.org>  Tue, 12 Aug 2008 20:41:27 +1000
> +
>  libx500-dn-perl (0.28-1) unstable; urgency=low
>  
>    * Initial Release.
>  
>   -- Alessandro Razeto <razeto@linux.it>  Sat,  4 Oct 2003 15:00:59 +0200
> -
> diff -Nru libx500-dn-perl-0.28/debian/compat libx500-dn-perl-0.29/debian/compat
> --- libx500-dn-perl-0.28/debian/compat	1970-01-01 10:00:00.000000000 +1000
> +++ libx500-dn-perl-0.29/debian/compat	2008-08-13 17:27:23.000000000 +1000
> @@ -0,0 +1 @@
> +7
> diff -Nru libx500-dn-perl-0.28/debian/control libx500-dn-perl-0.29/debian/control
> --- libx500-dn-perl-0.28/debian/control	2008-08-13 17:27:23.000000000 +1000
> +++ libx500-dn-perl-0.29/debian/control	2008-08-13 17:27:23.000000000 +1000
> @@ -1,9 +1,11 @@
>  Source: libx500-dn-perl
>  Section: perl
>  Priority: optional
> -Maintainer: Alessandro Razeto <razeto@linux.it>
> -Standards-Version: 3.6.0
> -Build-Depends-Indep: debhelper (>= 4.0.0), perl (>= 5.8.0-7)
> +Maintainer: Debian QA Group <packages@qa.debian.org>
> +Standards-Version: 3.8.0
> +Build-Depends: debhelper (>= 7)
> +Build-Depends-Indep: perl (>= 5.8.0-7)
> +Homepage: http://search.cpan.org/dist/X500-DN/
>  
>  Package: libx500-dn-perl
>  Section: perl
> @@ -12,4 +14,3 @@
>  Depends: ${perl:Depends}, libparse-recdescent-perl
>  Description: X500::DN provides a pure perl parser and formatter for RFC 2253
>   style DN strings.
> - .
> diff -Nru libx500-dn-perl-0.28/debian/copyright libx500-dn-perl-0.29/debian/copyright
> --- libx500-dn-perl-0.28/debian/copyright	2008-08-13 17:27:23.000000000 +1000
> +++ libx500-dn-perl-0.29/debian/copyright	2008-08-13 17:27:23.000000000 +1000
> @@ -1,7 +1,8 @@
>  This package was debianized by Alessandro Razeto <razeto@linux.it> on
>  Sat,  4 Oct 2003 15:00:59 +0200.
>  
> -It was downloaded from http://www.cpan.org/modules/by-module/X500/X500-DN-0.28.tar.gz
> +It was downloaded from
> +http://www.cpan.org/modules/by-module/X500/X500-DN-0.28.tar.gz
>  
This is probably not true.

>  Upstream Author: Robert Joop
>  
> diff -Nru libx500-dn-perl-0.28/debian/rules libx500-dn-perl-0.29/debian/rules
> --- libx500-dn-perl-0.28/debian/rules	2008-08-13 17:27:23.000000000 +1000
> +++ libx500-dn-perl-0.29/debian/rules	2008-08-13 17:27:23.000000000 +1000
> @@ -6,8 +6,6 @@
>  # Uncomment this to turn on verbose mode.
>  #export DH_VERBOSE=1
>  
> -export DH_COMPAT=4
> -
>  PACKAGE=$(shell dh_listpackages)
>  
>  ifndef PERL
> @@ -32,7 +30,7 @@
>  	rm -f build-stamp 
>  
>  	# Add here commands to clean up after the build process.
> -	-$(MAKE) clean
> +	[ ! -f Makefile ] || $(MAKE) clean
>  
>  	dh_clean 
>  
> @@ -47,11 +45,11 @@
>  
>  
>  # Build architecture-independent files here.
> -binary-indep: build install
> +binary-arch: build install
>  # We have nothing to do by default.
>  
>  # Build architecture-dependent files here.
> -binary-arch: build install
> +binary-indep: build install
>  	dh_testdir
>  	dh_testroot
>  	dh_installdocs README

Should have updated the comments while you were at it…

Cheers,
Julien


Reply to: