fix for 418284 for etch
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hello,
I have prepared a fix for the bug 418284 for etch. I think this fix
should be included since:
- - initial installations over pppoe might hit this bug
- - the fix is non-intusive and that trivial that would be a shame not
to have it
I have prepared a package for stable which is available at:
http://users.alioth.debian.org/~eddyp-guest/darcs/ppp-etch/
The diff relatively to the stable version is (broke by wrapping):
diff -ruN ../official/ppp-2.4.4rel/debian/changelog
ppp-2.4.4rel/debian/changelog
- --- ../official/ppp-2.4.4rel/debian/changelog 2007-04-10
11:03:01.000000000 +0300
+++ ppp-2.4.4rel/debian/changelog 2007-04-14
14:06:59.000000000 +0300
@@ -1,3 +1,10 @@
+ppp (2.4.4rel-8etch1) stable; urgency=low
+
+ * ppp-udeb: quote username and password in pap/chap secrets since
they
+ might contain special characters (Closes: 418284)
+
+ -- Eddy Petrișor <eddy.petrisor@gmail.com> Sat, 14 Apr 2007
14:05:44 +0300
+
ppp (2.4.4rel-8) unstable; urgency=high
* urgency high since fixes an RC bug
diff -ruN ../official/ppp-2.4.4rel/debian/ppp-udeb.postinst
ppp-2.4.4rel/debian/ppp-udeb.postinst
- --- ../official/ppp-2.4.4rel/debian/ppp-udeb.postinst 2007-04-10
11:03:01.000000000 +0300
+++ ppp-2.4.4rel/debian/ppp-udeb.postinst 2007-04-14
14:03:41.000000000 +0300
@@ -273,7 +273,7 @@
chmod 600 /etc/ppp/pap-secrets
cat <<EOF > /etc/ppp/pap-secrets
#GENERATED-BY-DEBIAN-INSTALLER#
- -$USERNAME * $PASSWORD
+"$USERNAME" * "$PASSWORD"
EOF
cp /etc/ppp/pap-secrets /etc/ppp/chap-secrets
The package built fine on my machine and the same fix was tested on
an unstable machine (while the stable and unstable versions started
to diverge now with this fix).
Here is the debdiff output relative to the newly uploaded version in
unstable.
debdiff ppp_2.4.4rel-8etch1_amd64.changes
../ppp-eddyp-dev/ppp_2.4.4rel-9_amd64.changes
File lists identical (after any substitutions)
Control files of package ppp: lines which differ (wdiff format)
- ---------------------------------------------------------------
Version: [-2.4.4rel-8etch1-] {+2.4.4rel-9+}
Control files of package ppp-dev: lines which differ (wdiff format)
- -------------------------------------------------------------------
Version: [-2.4.4rel-8etch1-] {+2.4.4rel-9+}
Control files of package ppp-udeb: lines which differ (wdiff format)
- --------------------------------------------------------------------
Version: [-2.4.4rel-8etch1-] {+2.4.4rel-9+}
Installer-Menu-Item: [-17-] {+1700+}
The 17 -> 1700 change is unstable specific.
One question, is "stable" ok as a distribution in this case?
- --
Regards,
EddyP
=============================================
"Imagination is more important than knowledge" A.Einstein
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
iD8DBQFGIMvAY8Chqv3NRNoRAgsyAKDEji0MrWY/16WeP9YD5qB9/FwTRwCgkSOe
mGEis6XHZCSvBPgzRqZ0VXw=
=j8zb
-----END PGP SIGNATURE-----
Reply to: