Re: Bug#317258: [stable] kernel upload to p-u
On Fri, Sep 14, 2007 at 07:03:32PM -0600, dann frazier wrote:
> I've modified the patch to also blacklist these controllers in the
> megaraid_mbox driver to avoid an overlap. I tested this patch on one
> of the 2M cards I have (which, for whatever reason, all work just fine
> with either driver).
And this is the problem. What is the different between the cards which
works with both and the cards which only works with legacy?
> --- linux-source-2.6.18.orig/drivers/scsi/megaraid/megaraid_mbox.c 2006-09-19 21:42:06.000000000 -0600
> +++ linux-source-2.6.18/drivers/scsi/megaraid/megaraid_mbox.c 2007-09-14 18:50:40.000000000 -0600
> @@ -426,6 +426,16 @@ megaraid_probe_one(struct pci_dev *pdev,
> con_log(CL_ANN, ("bus %d:slot %d:func %d\n", pdev->bus->number,
> PCI_SLOT(pdev->devfn), PCI_FUNC(pdev->devfn)));
>
> + /* Some NetRAID 1M and 2M controllers still require the old driver */
> + if (pdev->vendor == PCI_VENDOR_ID_AMI && \
> + pdev->device == PCI_DEVICE_ID_AMI_MEGARAID3 && \
> + pdev->subsystem_vendor == PCI_VENDOR_ID_HP && \
> + (pdev->subsystem_device == 0x60e7 || \
> + pdev->subsystem_device == 0x60e8)) {
Magic constants, coding style.
> + con_log(CL_ANN, ("megaraid_mbox: Blacklisted device found, aborting.\n"));
Useless message.
> + return -ENODEV;
Coding style.
Bastian
--
Suffocating together ... would create heroic camaraderie.
-- Khan Noonian Singh, "Space Seed", stardate 3142.8
Reply to: