Re: New GRUB package suitable for Etch
Hi Otavio,
On Thu, Mar 22, 2007 at 11:42:31PM -0300, Otavio Salvador wrote:
> I just did another upload of GRUB. The diff between -24 and -25 is a
> single line change.
Reviewing -24, there seems to be a shell error in the changes vs. -23:
++if [ -n ${rootdir} ]; then
If $rootdir is empty, this will give a syntax error because of the missing
argument to -n. Please quote this argument and upload a fix.
(The net result of this bug is that the find-grub-dir.diff added in -24 is
completely useless, since the script will only work if $rootdir is set,
which is what this patch was supposed to address.)
Further, the diff from -24 and -25 shows that you've changed the wrong
regexp to fix bug #414161 -- the relevant regexp for ccis systems is the
's%.*c[0-7]d[0-9]*p%%' one, and the interdiff shows that you've changed the
's%.*e[0-9]\.[0-9]*p%%' regexp instead.
Will unblock for etch if these problems get fixed.
Thanks,
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
vorlon@debian.org http://www.debian.org/
Reply to: