Re: please unblock FAI 3.1.7

[Steve Langasek <vorlon@debian.org>]

Hi Thomas,

On Wed, Feb 21, 2007 at 12:33:21PM +0100, Thomas Lange wrote:

> I like to ask you to unlock FAI 3.1.7.
> If fixes two important bugs (see bug numbers below), and includes two
> documentation fixes.

>   * subroutines: ifclass() should append to stderr (closes: #409059)
>   * examples/simple/, lib/fai-mount-disk, lib/mount2dir: use bash for
>     shell scripts (closes: #410084)  
>   * fix typo in bug number of older changelog entry
>   * install_packages.8: add info for variable MAXPACKAGES


@@ -61,7 +61,7 @@

 ifclass() {

-    [ "$debug" ] && echo "Test if class $1 is in $classes" >/dev/stderr
+    [ "$debug" ] && echo "Test if class $1 is in $classes" >>/dev/stderr
     # test if a class is defined
     local cl
     local ret=1
@@ -69,7 +69,7 @@
     for cl in $classes; do
        [ x$cl = x$1 ] && ret=0 && break
     done
-    [ "$debug" ] && echo "ifclass returns $ret" >/dev/stderr
+    [ "$debug" ] && echo "ifclass returns $ret" >>/dev/stderr
     return $ret
 }
 # - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Hrm, this is odd.  Why have you not simply written

     [ "$debug" ] && echo "Test if class $1 is in $classes" >&2

?

Thanks,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
vorlon@debian.org                                   http://www.debian.org/