[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Please unblock kqemu



On Wed, Jan 03, 2007 at 10:02:31PM +0100, Daniel Baumann wrote:
> Hi,
> 
> the current kqemu package in testing suffers from having no proper
> creation of the /dev/kqemu device. The -5 revision fixes this and
> slightly updates README.Debian.
> 
> Please unblock it, debdiff is attached.

  no, that cannot be done, your code is completely RC buggy, and IMHO
broken in the design anyway.

==============================================================================

  That feels wrong: why don't you ship the /etc/udev/kqemu.rules ?
Here, that chunk is already RC buggy, as you may overwrite a localy
created file without any check.

  the same is true for /etc/modprobe.d/kqemu

    diff -u kqemu-1.3.0~pre9/debian/kqemu-modules-_KVERS_.postinst.modules.in kqemu-1.3.0~pre9/debian/kqemu-modules-_KVERS_.postinst.modules.in
    --- kqemu-1.3.0~pre9/debian/kqemu-modules-_KVERS_.postinst.modules.in
    +++ kqemu-1.3.0~pre9/debian/kqemu-modules-_KVERS_.postinst.modules.in
    @@ -4,7 +4,17 @@

     case "${1}" in
	    configure)
    -		echo -n "  * Creating kqemu device: "
    +		if [ -d /etc/udev ]
    +		then
    +			# Creating /etc/udev/kqemu.rules
    +			echo 'KERNEL=="kqemu", MODE="0660", GROUP="kqemu"' > /etc/udev/kqemu.rules
    +
    +			# Creating /etc/udev/rules.d/099_kqemu.rules
    +			ln -sf ../kqemu.rules /etc/udev/rules.d/099_kqemu.rules
    +		fi
    +
    +		# Creating /etc/modprobe.d/kqemu
    +		echo 'options kqemu major=0' > /etc/modprobe.d/kqemu

		# Remove existing device
		if [ -e /dev/kqemu ]

==============================================================================

  This one is just plain wrong, that should be done on _purge_, not on
remove. and you wouldn't need to do that by shipping the file in the
first place from the package instead of manually dealing with it.

    diff -u kqemu-1.3.0~pre9/debian/kqemu-modules-_KVERS_.postrm.modules.in kqemu-1.3.0~pre9/debian/kqemu-modules-_KVERS_.postrm.modules.in
    --- kqemu-1.3.0~pre9/debian/kqemu-modules-_KVERS_.postrm.modules.in
    +++ kqemu-1.3.0~pre9/debian/kqemu-modules-_KVERS_.postrm.modules.in
    @@ -4,11 +4,10 @@
     
     case "${1}" in
	    remove)
    -		echo -n "  * Removing kqemu device: "
    -		
    +		rm -f /etc/udev/kqemu.rules
    +		rm -f /etc/udev/rules.d/099_kqemu.rules
    +		rm -f /etc/modprobe.d/kqemu
		rm -f /dev/kqemu
    -		
    -		echo "done."
		;;
 
	    purge|upgrade|failed-upgrade|abort-install|abort-upgrade|disappear)

==============================================================================
-- 
·O·  Pierre Habouzit
··O                                                madcoder@debian.org
OOO                                                http://www.madism.org

Attachment: pgp7cQ1CpuDCV.pgp
Description: PGP signature


Reply to: