[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: dpkg 1.13.24 hint and next upload



Hey Colin,

On Mon, 2006-12-11 at 17:08:45 +0000, Colin Watson wrote:
> On Sun, Nov 19, 2006 at 08:04:24AM +0200, Guillem Jover wrote:
> > The other one is to add lzma uncompressing support to dpkg and dpkg-dev,
> > so that the archive can start accepting this kind of packages for lenny,
> > otherwise we'd have to wait until lenny+1. I've been reluctant to
> > add this, as the lzma's CLI was not compatible with gzip,
> [...]
> > Index: lib/compression.c
> > ===================================================================
> > --- lib/compression.c	(revision 596)
> > +++ lib/compression.c	(working copy)
> > @@ -90,6 +90,17 @@
> >        }
> >        execlp(BZIP2,"bzip2","-dc",(char*)0); ohshite(_("%s: failed to exec bzip2 -dc"), v.buf);
> >  #endif
> > +    case compress_type_lzma:
> > +      if (fd_in != 0) {
> > +        m_dup2(fd_in, 0);
> > +        close(fd_in);
> > +      }
> > +      if (fd_out != 1) {
> > +        m_dup2(fd_out, 1);
> > +        close(fd_out);
> > +      }
> > +      execlp(LZMA, "lzma", "-dc", (char *)0);
> > +      ohshite(_("%s: failed to exec %s"), v.buf, "lzma -dc");
> >      case CAT:
> >        fd_fd_copy(fd_in, fd_out, -1, _("%s: decompression"), v.buf);
> >        exit(0);

> This would mean that every package using lzma compression would have to
> Pre-Depends: lzma.

Right, although I could move lzma from the Suggests to a Recommends
that does not guarantee anything, it would probably make it to be
installed in most of the desktops installations...

> Is there no way to do this using a statically linked
> library, the same way as we do for the other compression methods?

There's currently no static library for lzma, I talked with upstream
and one of the devels said that they plan to write one, but they are
still designing it. So it's a bad situation but I was considering
that maybe only really big packages are going to use it for now, like
game data sets or the like.

Although another option would be to embbed the lzma decompression code
into dpkg (there's a proposed patch in the BTS), that would solve
these issues, but it seems a bit nasty as well, and it's potentially
more work for the security team...

regards,
guillem



Reply to: