[red_socks@gmx.de: Bug#378484: Roundup server does not setgid to specified GID when starting as root]

[Toni Mueller <toni@debian.org>]

Hello,

would this qualify for inclusion in a point release (ref.
http://www.debian.org/doc/developers-reference/ch-pkgs.en.html#s-upload-stable)?

If yes, I'd try to create such a fixed package.


Best,
--Toni++

----- Forwarded message from Frank Hempel <red_socks@gmx.de> -----

Date: Sun, 16 Jul 2006 19:41:29 +0200
From: Frank Hempel <red_socks@gmx.de>
To: submit@bugs.debian.org
Subject: Bug#378484: Roundup server does not setgid to specified GID when starting as root
Reply-To: Frank Hempel <red_socks@gmx.de>, 378484@bugs.debian.org

Package: roundup
Version: 0.8.2-1

When starting roundup (as root) and specifying with the -g switch the 
GID it should run as, the following warning is printed out:
WARNING: ignoring "-g" argument, not root
The server then still runs with root-GID.

The attached patch fixes this.

This bug is not present in above versions of roundup (0.8.6 or 1.1.2).

--- roundup_server.py.debPkg	2005-03-03 15:19:51.000000000 +0100
+++ roundup_server.py	2006-07-16 02:22:19.000000000 +0200
@@ -252,7 +252,7 @@
         return
 
     # if root, setgid to the running user
-    if not os.getuid():
+    if os.getuid():
         print _('WARNING: ignoring "-g" argument, not root')
         return
 


----- End forwarded message -----