please allow hylafax 4.3.1-6 in etch
Hi all,
I received two e-mail from people having problems with the latest
hylafax packages. These problems where related to four shell variables
that select which external programs should be used in order to encode
e-mail body and attachments: uuencode, mimencode, qp-encode.
Moreover I got one new bug report that showed the same problem described
above and a new problem related to some unwanted output from ps2pdf (See
#404405).
To fix these problems I created three new version of hylafax package.
These version only have small changes between them. The last version,
2:4.3.1-6, fix all those problems.
This is a list of the difference between the versions in unstable
(2:4.3.1-6) and testing (2:4.3.1-3):
0. a new patch from upstream for fixing the way commands are stored in
shell variables. 4 variables are now correctly quoted.
diff -urNad hylafax-4.3.1~/etc/faxsetup.sh.in hylafax-4.3.1/etc/faxsetup.sh.in
--- hylafax-4.3.1~/etc/faxsetup.sh.in 2006-12-24 21:36:08.000000000 +0100
+++ hylafax-4.3.1/etc/faxsetup.sh.in 2006-12-24 21:37:05.000000000 +0100
@@ -49,7 +49,7 @@
test -d /usr/local/bin && PATH=$PATH:/usr/local/bin # for GNU tools
AWK=@AWK@ # awk for use below
-BASE64ENCODE=@BASE64ENCODE@ # base64encode command to dump in setup.cache
+BASE64ENCODE='@BASE64ENCODE@' # base64encode command to dump in setup.cache
CAT=@CAT@ # cat command for use below
CHARSET=@CHARSET@ # character set to use in e-mails
CHGRP=@CHGRP@ # change file group for use below
@@ -62,16 +62,16 @@
GREP=@GREP@ # grep command for use below
LN=@LN@ # ln command for use below
LN_S=@LN_S@ # ln option for creating a symbolic link
-MIMENCODE=@MIMENCODE@ # mimencode command to dump in setup.cache
+MIMENCODE='@MIMENCODE@' # mimencode command to dump in setup.cache
MKFIFO=@MKFIFO@ # FIFO creation program for use below
MV=@MV@ # move file for use below
-QPENCODE=@QPENCODE@ # qpencode command to dump in setup.cache
+QPENCODE='@QPENCODE@' # qpencode command to dump in setup.cache
RMCMD=@RM@ # remove file for use below
SCRIPT_SH=@SCRIPT_SH@ # shell for use below
SED=@SED@ # sed for use below
TIFF2PDF=@TIFF2PDF@ # tiff-to-pdf conversion tool
TTYCMD=@TTYCMD@ # tty for error output
-UUENCODE=@UUENCODE@ # uuencode command to dump in setup.cache
+UUENCODE='@UUENCODE@' # uuencode command to dump in setup.cache
FAX=@FAXUID@ # identity of the fax user
SERVICES=/etc/services # location of services database
1. a new one line patch for removing unwanted output in ps2pdf
invocation
diff -urNad hylafax-4.3.1~/util/common-functions.sh.in hylafax-4.3.1/util/common-functions.sh.in
--- hylafax-4.3.1~/util/common-functions.sh.in 2006-11-22 19:38:35.000000000 +0100
+++ hylafax-4.3.1/util/common-functions.sh.in 2006-12-24 21:33:24.000000000 +0100
@@ -377,7 +377,7 @@
PostScript|Postscript|PS|ps)
TraceLog "Using ps2pdf"
name="`basename $1 .ps`"
- $PS2PDF $1 $TMPDIR/$name.pdf
+ $PS2PDF $1 $TMPDIR/$name.pdf >/dev/null 2>&1
echo "$TMPDIR/$name.pdf"
;;
PDF|pdf)
2. a new one line patch that change the way grep is invoked. This is a
quite important patch since the previous code lead grep to fails.
diff -urNad hylafax-4.3.1~/util/notify.sh.in hylafax-4.3.1/util/notify.sh.in
--- hylafax-4.3.1~/util/notify.sh.in 2006-12-24 16:53:53.000000000 +0100
+++ hylafax-4.3.1/util/notify.sh.in 2006-12-24 16:54:30.000000000 +0100
@@ -169,7 +169,7 @@
# We need a few special things
## - SESSION_LOG
if [ -f "log/c$commid" ]; then
- SESSION_LOG="`cat log/c$commid | grep -v '-- data'`"
+ SESSION_LOG="`cat log/c$commid | grep -v -- '-- data'`"
fi
if [ "$doneop" = "default" ] ; then
I would suggest to have this version in etch instead of 2:4.3.1-3. It is
not a large diff and will fix at least a very important problem (2.)
Reply to: