[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Easy removals: B



tag 362959 =
tag 362959 + patch
thanks

  I confirm. I have tracked that issue down, it's because upstream takes
pointer on things that should be gsizes (aka 64 bits on amd64) on things
that are gints (32bits).

  it had the nice effect to reset a loop counter to 0, hence the 100%
CPU loop.

  attached a patch that fixes that.

  Also not that some compilation warnings remains (I've no gtk/glib
knowledge, but those are grave on 64bits machines usually):

    callback_func.c: In function ‘callback_show_team’:
    callback_func.c:584: warning: cast to pointer from integer of different size
    callback_func.c:589: warning: cast to pointer from integer of different size

    game.c: In function ‘game_assign_attendance_neutral’:
    game.c:416: warning: cast to pointer from integer of different size

    league.c: In function ‘league_cup_average_capacity’:
    league.c:309: warning: cast to pointer from integer of different size
    league.c:319: warning: cast to pointer from integer of different size

    misc_interface.c: In function ‘create_window_file_chooser’:
    misc_interface.c:1231: warning: not enough variable arguments to fit a sentinel

    treeview.c: In function ‘treeview_show_all_players’:
    treeview.c:1814: warning: cast to pointer from integer of different size
    treeview.c:1823: warning: cast to pointer from integer of different size

though it has not triggered any obvious crash atm.


On Wed, May 10, 2006 at 01:39:40AM -0700, Steve Langasek wrote:
> severity 362959 grave
> thanks
> 
> On Wed, May 10, 2006 at 08:12:26AM +0200, Isaac Clerencia wrote:
> > On Wednesday 10 May 2006 07:48, Steve Langasek wrote:
> > > > # 362959
> > > > remove bygfoot/1.9.4-1
> > >
> > > Seems to be pretty unreproducible across most architectures, may not even
> > > be a bug anymore -- deferred for the moment.
> > I've downgraded the severity to normal and marked as unreproducible, may be it 
> > was a gtk bug?
> 
> Nope, still reproducible in unstable on amd64.
-- 
·O·  Pierre Habouzit
··O                                                madcoder@debian.org
OOO                                                http://www.madism.org
Seulement dans bygfoot-1.9.4.patched/src: bet.o
Seulement dans bygfoot-1.9.4.patched/src: bygfoot
Seulement dans bygfoot-1.9.4.patched/src: callback_func.o
Seulement dans bygfoot-1.9.4.patched/src: callbacks.o
Seulement dans bygfoot-1.9.4.patched/src: cup.o
Seulement dans bygfoot-1.9.4.patched/src: debug.o
Seulement dans bygfoot-1.9.4.patched/src: .deps
Seulement dans bygfoot-1.9.4.patched/src: f
Seulement dans bygfoot-1.9.4.patched/src: file.o
Seulement dans bygfoot-1.9.4.patched/src: finance.o
Seulement dans bygfoot-1.9.4.patched/src: fixture.o
Seulement dans bygfoot-1.9.4.patched/src: free.o
Seulement dans bygfoot-1.9.4.patched/src: .f.swp
Seulement dans bygfoot-1.9.4.patched/src: game_gui.o
Seulement dans bygfoot-1.9.4.patched/src: game.o
Seulement dans bygfoot-1.9.4.patched/src: gui.o
Seulement dans bygfoot-1.9.4.patched/src: interface.o
Seulement dans bygfoot-1.9.4.patched/src: job.o
Seulement dans bygfoot-1.9.4.patched/src: .kdbgrc.bygfoot
Seulement dans bygfoot-1.9.4.patched/src: language.o
Seulement dans bygfoot-1.9.4.patched/src: league.o
Seulement dans bygfoot-1.9.4.patched/src: lg_commentary.o
Seulement dans bygfoot-1.9.4.patched/src: live_game.o
Seulement dans bygfoot-1.9.4.patched/src: load_save.o
Seulement dans bygfoot-1.9.4.patched/src: main.o
Seulement dans bygfoot-1.9.4.patched/src: Makefile
Seulement dans bygfoot-1.9.4.patched/src: maths.o
Seulement dans bygfoot-1.9.4.patched/src: misc2_callback_func.o
Seulement dans bygfoot-1.9.4.patched/src: misc2_callbacks.o
Seulement dans bygfoot-1.9.4.patched/src: misc2_interface.o
Seulement dans bygfoot-1.9.4.patched/src: misc3_callbacks.o
Seulement dans bygfoot-1.9.4.patched/src: misc3_interface.o
Seulement dans bygfoot-1.9.4.patched/src: misc_callback_func.o
Seulement dans bygfoot-1.9.4.patched/src: misc_callbacks.o
Seulement dans bygfoot-1.9.4.patched/src: misc_interface.o
Seulement dans bygfoot-1.9.4.patched/src: misc.o
Seulement dans bygfoot-1.9.4.patched/src: name.o
Seulement dans bygfoot-1.9.4.patched/src: option_gui.o
Seulement dans bygfoot-1.9.4.patched/src: option.o
Seulement dans bygfoot-1.9.4.patched/src: options_callbacks.o
Seulement dans bygfoot-1.9.4.patched/src: options_interface.o
Seulement dans bygfoot-1.9.4.patched/src: player.o
Seulement dans bygfoot-1.9.4.patched/src: start_end.o
Seulement dans bygfoot-1.9.4.patched/src: stat.o
Seulement dans bygfoot-1.9.4.patched/src: strategy.o
Seulement dans bygfoot-1.9.4.patched/src: support_files
Seulement dans bygfoot-1.9.4.patched/src: support.o
Seulement dans bygfoot-1.9.4.patched/src: table.o
Seulement dans bygfoot-1.9.4.patched/src: .tags
Seulement dans bygfoot-1.9.4.patched/src: team.o
Seulement dans bygfoot-1.9.4.patched/src: transfer.o
Seulement dans bygfoot-1.9.4.patched/src: treeview2.o
Seulement dans bygfoot-1.9.4.patched/src: treeview_helper.o
Seulement dans bygfoot-1.9.4.patched/src: treeview.o
Seulement dans bygfoot-1.9.4.patched/src: user.o
Seulement dans bygfoot-1.9.4.patched/src: window.o
diff -ura bygfoot-1.9.4/src/xml_country.c bygfoot-1.9.4.patched/src/xml_country.c
--- bygfoot-1.9.4/src/xml_country.c	2005-12-22 10:44:34.000000000 +0100
+++ bygfoot-1.9.4.patched/src/xml_country.c	2006-05-28 21:22:16.000000000 +0200
@@ -206,7 +206,7 @@
 			    xml_country_read_text, NULL, NULL};
     GMarkupParseContext *context;
     gchar *file_contents;
-    gint length;
+    gsize length;
     GError *error = NULL;
     gchar buf[SMALL];
     gint i;
Seulement dans bygfoot-1.9.4.patched/src: xml_country.o
diff -ura bygfoot-1.9.4/src/xml_cup.c bygfoot-1.9.4.patched/src/xml_cup.c
--- bygfoot-1.9.4/src/xml_cup.c	2005-12-22 10:44:34.000000000 +0100
+++ bygfoot-1.9.4.patched/src/xml_cup.c	2006-05-28 21:22:08.000000000 +0200
@@ -357,7 +357,7 @@
 			    xml_cup_read_text, NULL, NULL};
     GMarkupParseContext *context;
     gchar *file_contents;
-    gint length;
+    gsize length;
     GError *error = NULL;
     gchar buf[SMALL];
 
Seulement dans bygfoot-1.9.4.patched/src: xml_cup.o
diff -ura bygfoot-1.9.4/src/xml_league.c bygfoot-1.9.4.patched/src/xml_league.c
--- bygfoot-1.9.4/src/xml_league.c	2005-12-22 10:44:34.000000000 +0100
+++ bygfoot-1.9.4.patched/src/xml_league.c	2006-05-28 21:22:21.000000000 +0200
@@ -388,7 +388,7 @@
 			    xml_league_read_text, NULL, NULL};
     GMarkupParseContext *context;
     gchar *file_contents;
-    gint length;
+    gsize length;
     GError *error = NULL;
     gchar buf[SMALL];
 
Seulement dans bygfoot-1.9.4.patched/src: xml_league.o
diff -ura bygfoot-1.9.4/src/xml_lg_commentary.c bygfoot-1.9.4.patched/src/xml_lg_commentary.c
--- bygfoot-1.9.4/src/xml_lg_commentary.c	2005-12-22 10:44:34.000000000 +0100
+++ bygfoot-1.9.4.patched/src/xml_lg_commentary.c	2006-05-28 21:22:27.000000000 +0200
@@ -272,7 +272,7 @@
 			    xml_lg_commentary_read_text, NULL, NULL};
     GMarkupParseContext *context;
     gchar *file_contents;
-    gint length;
+    gsize length;
     GError *error = NULL;
 
     context = 
Seulement dans bygfoot-1.9.4.patched/src: xml_lg_commentary.o
diff -ura bygfoot-1.9.4/src/xml_loadsave_cup.c bygfoot-1.9.4.patched/src/xml_loadsave_cup.c
--- bygfoot-1.9.4/src/xml_loadsave_cup.c	2005-12-22 10:44:34.000000000 +0100
+++ bygfoot-1.9.4.patched/src/xml_loadsave_cup.c	2006-05-28 21:21:13.000000000 +0200
@@ -282,7 +282,7 @@
 			    xml_loadsave_cup_text, NULL, NULL};
     GMarkupParseContext *context;
     gchar *file_contents = NULL;
-    guint length;
+    gsize length;
     GError *error = NULL;
 
     context = 
Seulement dans bygfoot-1.9.4.patched/src: xml_loadsave_cup.o
diff -ura bygfoot-1.9.4/src/xml_loadsave_fixtures.c bygfoot-1.9.4.patched/src/xml_loadsave_fixtures.c
--- bygfoot-1.9.4/src/xml_loadsave_fixtures.c	2005-12-22 10:44:34.000000000 +0100
+++ bygfoot-1.9.4.patched/src/xml_loadsave_fixtures.c	2006-05-28 21:21:19.000000000 +0200
@@ -177,7 +177,7 @@
 			    xml_loadsave_fixtures_text, NULL, NULL};
     GMarkupParseContext *context;
     gchar *file_contents;
-    guint length;
+    gsize length;
     GError *error = NULL;
 
     context = 
Seulement dans bygfoot-1.9.4.patched/src: xml_loadsave_fixtures.o
diff -ura bygfoot-1.9.4/src/xml_loadsave_jobs.c bygfoot-1.9.4.patched/src/xml_loadsave_jobs.c
--- bygfoot-1.9.4/src/xml_loadsave_jobs.c	2005-12-22 10:44:34.000000000 +0100
+++ bygfoot-1.9.4.patched/src/xml_loadsave_jobs.c	2006-05-28 21:21:24.000000000 +0200
@@ -152,7 +152,7 @@
 			    xml_loadsave_jobs_text, NULL, NULL};
     GMarkupParseContext *context;
     gchar *file_contents;
-    guint length;
+    gsize length;
     GError *error = NULL;
     gchar file[SMALL];
 
Seulement dans bygfoot-1.9.4.patched/src: xml_loadsave_jobs.o
diff -ura bygfoot-1.9.4/src/xml_loadsave_league.c bygfoot-1.9.4.patched/src/xml_loadsave_league.c
--- bygfoot-1.9.4/src/xml_loadsave_league.c	2005-12-22 10:44:34.000000000 +0100
+++ bygfoot-1.9.4.patched/src/xml_loadsave_league.c	2006-05-28 21:21:29.000000000 +0200
@@ -212,7 +212,7 @@
 			    xml_loadsave_league_text, NULL, NULL};
     GMarkupParseContext *context;
     gchar *file_contents;
-    guint length;
+    gsize length;
     GError *error = NULL;
 
     context = 
Seulement dans bygfoot-1.9.4.patched/src: xml_loadsave_league.o
diff -ura bygfoot-1.9.4/src/xml_loadsave_leagues_cups.c bygfoot-1.9.4.patched/src/xml_loadsave_leagues_cups.c
--- bygfoot-1.9.4/src/xml_loadsave_leagues_cups.c	2005-12-22 10:44:34.000000000 +0100
+++ bygfoot-1.9.4.patched/src/xml_loadsave_leagues_cups.c	2006-05-28 21:21:34.000000000 +0200
@@ -117,7 +117,7 @@
 			    xml_loadsave_leagues_cups_text, NULL, NULL};
     GMarkupParseContext *context;
     gchar *file_contents;
-    guint length;
+    gsize length;
     GError *error = NULL;
 
     sprintf(file, "%s%s%s___leagues_cups.xml", dirname, G_DIR_SEPARATOR_S, prefix);
Seulement dans bygfoot-1.9.4.patched/src: xml_loadsave_leagues_cups.o
diff -ura bygfoot-1.9.4/src/xml_loadsave_league_stat.c bygfoot-1.9.4.patched/src/xml_loadsave_league_stat.c
--- bygfoot-1.9.4/src/xml_loadsave_league_stat.c	2005-12-22 10:44:34.000000000 +0100
+++ bygfoot-1.9.4.patched/src/xml_loadsave_league_stat.c	2006-05-28 21:21:38.000000000 +0200
@@ -180,7 +180,7 @@
 			    xml_loadsave_league_stat_text, NULL, NULL};
     GMarkupParseContext *context;
     gchar *file_contents;
-    guint length;
+    gsize length;
     GError *error = NULL;
 
     context = 
Seulement dans bygfoot-1.9.4.patched/src: xml_loadsave_league_stat.o
diff -ura bygfoot-1.9.4/src/xml_loadsave_live_game.c bygfoot-1.9.4.patched/src/xml_loadsave_live_game.c
--- bygfoot-1.9.4/src/xml_loadsave_live_game.c	2005-12-22 10:44:34.000000000 +0100
+++ bygfoot-1.9.4.patched/src/xml_loadsave_live_game.c	2006-05-28 21:21:42.000000000 +0200
@@ -231,7 +231,7 @@
 			    xml_loadsave_live_game_text, NULL, NULL};
     GMarkupParseContext *context;
     gchar *file_contents;
-    guint length;
+    gsize length;
     GError *error = NULL;
 
     context = 
Seulement dans bygfoot-1.9.4.patched/src: xml_loadsave_live_game.o
diff -ura bygfoot-1.9.4/src/xml_loadsave_misc.c bygfoot-1.9.4.patched/src/xml_loadsave_misc.c
--- bygfoot-1.9.4/src/xml_loadsave_misc.c	2005-12-22 10:44:34.000000000 +0100
+++ bygfoot-1.9.4.patched/src/xml_loadsave_misc.c	2006-05-28 21:21:45.000000000 +0200
@@ -186,7 +186,7 @@
 			    xml_loadsave_misc_text, NULL, NULL};
     GMarkupParseContext *context;
     gchar *file_contents;
-    guint length;
+    gsize length;
     GError *error = NULL;
 
     sprintf(file, "%s%s%s___misc.xml", dirname, G_DIR_SEPARATOR_S, basename);
Seulement dans bygfoot-1.9.4.patched/src: xml_loadsave_misc.o
Seulement dans bygfoot-1.9.4.patched/src: xml_loadsave_players.o
diff -ura bygfoot-1.9.4/src/xml_loadsave_season_stats.c bygfoot-1.9.4.patched/src/xml_loadsave_season_stats.c
--- bygfoot-1.9.4/src/xml_loadsave_season_stats.c	2005-12-22 10:44:34.000000000 +0100
+++ bygfoot-1.9.4.patched/src/xml_loadsave_season_stats.c	2006-05-28 21:21:47.000000000 +0200
@@ -165,7 +165,7 @@
 			    xml_loadsave_season_stats_text, NULL, NULL};
     GMarkupParseContext *context;
     gchar *file_contents;
-    guint length;
+    gsize length;
     GError *error = NULL;
 
     context = 
Seulement dans bygfoot-1.9.4.patched/src: xml_loadsave_season_stats.o
diff -ura bygfoot-1.9.4/src/xml_loadsave_table.c bygfoot-1.9.4.patched/src/xml_loadsave_table.c
--- bygfoot-1.9.4/src/xml_loadsave_table.c	2005-12-22 10:44:34.000000000 +0100
+++ bygfoot-1.9.4.patched/src/xml_loadsave_table.c	2006-05-28 21:21:50.000000000 +0200
@@ -146,7 +146,7 @@
 			    xml_loadsave_table_text, NULL, NULL};
     GMarkupParseContext *context;
     gchar *file_contents;
-    guint length;
+    gsize length;
     GError *error = NULL;
 
     context = 
Seulement dans bygfoot-1.9.4.patched/src: xml_loadsave_table.o
diff -ura bygfoot-1.9.4/src/xml_loadsave_teams.c bygfoot-1.9.4.patched/src/xml_loadsave_teams.c
--- bygfoot-1.9.4/src/xml_loadsave_teams.c	2005-12-22 10:44:34.000000000 +0100
+++ bygfoot-1.9.4.patched/src/xml_loadsave_teams.c	2006-05-28 21:21:53.000000000 +0200
@@ -200,7 +200,7 @@
 			    xml_loadsave_teams_text, NULL, NULL};
     GMarkupParseContext *context;
     gchar *file_contents;
-    guint length;
+    gsize length;
     GError *error = NULL;
 
     context = 
Seulement dans bygfoot-1.9.4.patched/src: xml_loadsave_teams.o
diff -ura bygfoot-1.9.4/src/xml_loadsave_transfers.c bygfoot-1.9.4.patched/src/xml_loadsave_transfers.c
--- bygfoot-1.9.4/src/xml_loadsave_transfers.c	2005-12-22 10:44:34.000000000 +0100
+++ bygfoot-1.9.4.patched/src/xml_loadsave_transfers.c	2006-05-28 21:21:57.000000000 +0200
@@ -168,7 +168,7 @@
 			    xml_loadsave_transfers_text, NULL, NULL};
     GMarkupParseContext *context;
     gchar *file_contents;
-    guint length;
+    gsize length;
     GError *error = NULL;
 
     context = 
Seulement dans bygfoot-1.9.4.patched/src: xml_loadsave_transfers.o
diff -ura bygfoot-1.9.4/src/xml_loadsave_users.c bygfoot-1.9.4.patched/src/xml_loadsave_users.c
--- bygfoot-1.9.4/src/xml_loadsave_users.c	2005-12-22 10:44:34.000000000 +0100
+++ bygfoot-1.9.4.patched/src/xml_loadsave_users.c	2006-05-28 21:22:00.000000000 +0200
@@ -331,7 +331,7 @@
 			    xml_loadsave_users_text, NULL, NULL};
     GMarkupParseContext *context;
     gchar *file_contents;
-    guint length;
+    gsize length;
     GError *error = NULL;
     gchar file[SMALL];
 
Seulement dans bygfoot-1.9.4.patched/src: xml_loadsave_users.o
diff -ura bygfoot-1.9.4/src/xml_mmatches.c bygfoot-1.9.4.patched/src/xml_mmatches.c
--- bygfoot-1.9.4/src/xml_mmatches.c	2005-12-22 10:44:34.000000000 +0100
+++ bygfoot-1.9.4.patched/src/xml_mmatches.c	2006-05-28 21:22:31.000000000 +0200
@@ -142,7 +142,7 @@
 			    xml_mmatches_text, NULL, NULL};
     GMarkupParseContext *context;
     gchar *file_contents;
-    guint length;
+    gsize length;
     GError *error = NULL;
 
     context = 
Seulement dans bygfoot-1.9.4.patched/src: xml_mmatches.o
diff -ura bygfoot-1.9.4/src/xml_name.c bygfoot-1.9.4.patched/src/xml_name.c
--- bygfoot-1.9.4/src/xml_name.c	2005-12-22 10:44:34.000000000 +0100
+++ bygfoot-1.9.4.patched/src/xml_name.c	2006-05-28 21:22:35.000000000 +0200
@@ -114,7 +114,7 @@
 			    xml_name_read_text, NULL, NULL};
     GMarkupParseContext *context;
     gchar *file_contents;
-    gint length;
+    gsize length;
     GError *error = NULL;
     gchar buf[SMALL];
 
Seulement dans bygfoot-1.9.4.patched/src: xml_name.o
Seulement dans bygfoot-1.9.4.patched/src: xml.o
diff -ura bygfoot-1.9.4/src/xml_strategy.c bygfoot-1.9.4.patched/src/xml_strategy.c
--- bygfoot-1.9.4/src/xml_strategy.c	2005-12-22 10:44:34.000000000 +0100
+++ bygfoot-1.9.4.patched/src/xml_strategy.c	2006-05-28 21:19:51.000000000 +0200
@@ -470,7 +470,7 @@
 			    xml_strategy_read_text, NULL, NULL};
     GMarkupParseContext *context;
     gchar *file_contents;
-    gint length;
+    gsize length;
     GError *error = NULL;
 
     context = 
Seulement dans bygfoot-1.9.4.patched/src: xml_strategy.o
diff -ura bygfoot-1.9.4/src/xml_team.c bygfoot-1.9.4.patched/src/xml_team.c
--- bygfoot-1.9.4/src/xml_team.c	2005-12-22 10:44:35.000000000 +0100
+++ bygfoot-1.9.4.patched/src/xml_team.c	2006-05-28 21:22:48.000000000 +0200
@@ -229,7 +229,7 @@
 			    xml_team_read_text, NULL, NULL};
     GMarkupParseContext *context;
     gchar *file_contents;
-    gint length;
+    gsize length;
     GError *error = NULL;
 
     team = tm;
Seulement dans bygfoot-1.9.4.patched/src: xml_team.o
Seulement dans bygfoot-1.9.4.patched/src: youth_academy.o

Attachment: signature.asc
Description: Digital signature


Reply to: